You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2026/07/28 20:09:14 UTC
[Impala-ASF-CR] IMPALA-15228: Make dockerized test script compatible with Ninja
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24638
Change subject: IMPALA-15228: Make dockerized test script compatible with Ninja
......................................................................
IMPALA-15228: Make dockerized test script compatible with Ninja
Impala builds started leaning on Ninja for better concurrency management
during compile and link phases.
The test driver script for dockerized test runs hard-coded a call to
'make', which breaks during a build driven by Ninja, so this patch
changes that call to Impala's alias for the current make tool,
S{IMPALA_MAKE_CMD} to stay compatible.
The patch also fixes a potentially undefined environment variable on the
same line.
Change-Id: If32985d1222c5f6411ac306d21b0390627bdc2a8
---
M bin/jenkins/dockerized-impala-run-tests.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/24638/1
--
To view, visit http://gerrit.cloudera.org:8080/24638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If32985d1222c5f6411ac306d21b0390627bdc2a8
Gerrit-Change-Number: 24638
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-15228: Make dockerized test script compatible with Ninja
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24638 )
Change subject: IMPALA-15228: Make dockerized test script compatible with Ninja
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/23424/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If32985d1222c5f6411ac306d21b0390627bdc2a8
Gerrit-Change-Number: 24638
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jul 2026 20:31:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15228: Make dockerized test script compatible with Ninja
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has abandoned this change. ( http://gerrit.cloudera.org:8080/24638 )
Change subject: IMPALA-15228: Make dockerized test script compatible with Ninja
......................................................................
Abandoned
It's a duplicate, probably because a rebase messed up the ChangeIDs
--
To view, visit http://gerrit.cloudera.org:8080/24638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If32985d1222c5f6411ac306d21b0390627bdc2a8
Gerrit-Change-Number: 24638
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>