You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/11 08:29:16 UTC
[GitHub] [arrow] liyafan82 commented on pull request #8210: ARROW-10031: [CI][Java] Support Java benchmark in Ursabot
liyafan82 commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-725281667
> At my end, I can generate the following JSON file by `archery benchmark diff --language=java ...`
>
> @liyafan82 any comments regarding format and parameters are appreciated.
>
> ```
> benchmark baseline contender change % counters
> 0 org.apache.arrow.vector.IntBenchmarks.setIntDirectly 22.500 us/op 11.209 us/op -50.182 {'mode': 'avgt', 'threads': 1, 'warmups': 5, 'warmupTime': '10 s', 'measurements': 4, 'measurementTime': '10 s', 'jvmArgs': ['-Darrow.enable_null_check_for_get=false -Darrow.enable_unsafe_memory_access=true']}
> 2 org.apache.arrow.vector.IntBenchmarks.setWithValueHolder 19.031 us/op 6.627 us/op -65.179 {'mode': 'avgt', 'threads': 1, 'warmups': 5, 'warmupTime': '10 s', 'measurements': 4, 'measurementTime': '10 s', 'jvmArgs': ['-Darrow.enable_null_check_for_get=false -Darrow.enable_unsafe_memory_access=true']}
> 1 org.apache.arrow.vector.IntBenchmarks.setWithWriter 32.626 us/op 10.246 us/op -68.594 {'mode': 'avgt', 'threads': 1, 'warmups': 5, 'warmupTime': '10 s', 'measurements': 4, 'measurementTime': '10 s', 'jvmArgs': ['-Darrow.enable_null_check_for_get=false -Darrow.enable_unsafe_memory_access=true']}
> ```
@kiszk Thanks for your effort. Generally, it looks great! Some minor comments:
1. It is clearer to rename title 'counters' to 'configuration'?
2. I am curious how are the benchmarks sorted, by 'change %'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org