You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/08/12 13:04:52 UTC

Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/
-----------------------------------------------------------

Review request for cloudstack, Doug Clark and Santhosh Edukulla.


Bugs: CLOUDSTACK-7284
    https://issues.apache.org/jira/browse/CLOUDSTACK-7284


Repository: cloudstack-git


Description
-------

The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.


Diffs
-----

  test/integration/component/test_add_remove_network.py 2bd6ec2 

Diff: https://reviews.apache.org/r/24599/diff/


Testing
-------

Yes.

Log:
update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 394.165s

OK


Thanks,

Gaurav Aradhye


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50320
-----------------------------------------------------------


Commit 045a290cec2dbdf9b284934a4cd92836c227d513 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=045a290 ]

CLOUDSTACK-7284: Fixed cleanup issue in test_escalations_snapshots.py


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50321
-----------------------------------------------------------


Commit 07abf7d7c1cd4953bea0322f21aeb8379fc49e14 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=07abf7d ]

CLOUDSTACK-7284: Fixed VM delete issue, expunge not allowed by user api client


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50417
-----------------------------------------------------------


Commit 76cecc325fca5ead8b610c49608cb8fe8a4395c5 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=76cecc3 ]

CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50322
-----------------------------------------------------------


Commit 97ecd5575c4b408ecb4e08a1b81933bb703b324a in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97ecd55 ]

CLOUDSTACK-7284: Fixed cleanup issue in test_escalations_instances.py, VM should be deleted before deleting the network


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50449
-----------------------------------------------------------


Commit f6bde7b46bb09aa13cb35049716bd7e1fc5b7774 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f6bde7b ]

CLOUDSTACK-7284: Fixed string issue in test_snapshots.py


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24599/#review50453
-----------------------------------------------------------


Commit 5f893daa2cab381aef6ac59eeebe923373c4ea80 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5f893da ]

CLOUDSTACK-7284: Fixed regression issue in test_escalations_instances.py


- ASF Subversion and Git Services


On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24599/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2014, 11:04 a.m.)
> 
> 
> Review request for cloudstack, Doug Clark and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7284
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7284
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case was failing while listing the VM after destroying it and verifying that it is destroyed.
> As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py 2bd6ec2 
> 
> Diff: https://reviews.apache.org/r/24599/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 394.165s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>