You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/01 13:28:03 UTC
[GitHub] [incubator-eventmesh] weihubeats opened a new pull request, #2354: reconstruct ClientManageController
weihubeats opened a new pull request, #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354
Fixes https://github.com/apache/incubator-eventmesh/issues/2353
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2354: [ISSUE #2353] reconstruct ClientManageController
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #2354: [Enhancement] reconstruct ClientManageController
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354#issuecomment-1334816675
> Modified pr name, is that what it means?
ok，like other pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2354: reconstruct ClientManageController
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354#issuecomment-1333837118
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2354](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a3ad62) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/8c31f73ffa7a2ad5e02273cd9d4aa7128bd05a4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c31f73) will **increase** coverage by `0.02%`.
> The diff coverage is `54.34%`.
> :exclamation: Current head 7a3ad62 differs from pull request most recent head c890850. Consider uploading reports for the commit c890850 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2354 +/- ##
============================================
+ Coverage 11.72% 11.75% +0.02%
- Complexity 894 899 +5
============================================
Files 471 473 +2
Lines 27810 27851 +41
Branches 3007 2992 -15
============================================
+ Hits 3262 3275 +13
- Misses 24248 24283 +35
+ Partials 300 293 -7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/eventmesh/common/protocol/tcp/codec/Codec.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC90Y3AvY29kZWMvQ29kZWMuamF2YQ==) | `61.79% <0.00%> (ø)` | |
| [...eventmesh/metrics/api/model/TcpSummaryMetrics.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL21ldHJpY3MvYXBpL21vZGVsL1RjcFN1bW1hcnlNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tmesh/runtime/metrics/tcp/EventMeshTcpMonitor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL21ldHJpY3MvdGNwL0V2ZW50TWVzaFRjcE1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/eventmesh/common/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9Kc29uVXRpbHMuamF2YQ==) | `16.66% <11.53%> (-14.11%)` | :arrow_down: |
| [...e/admin/handler/QueryWebHookConfigByIdHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlXZWJIb29rQ29uZmlnQnlJZEhhbmRsZXIuamF2YQ==) | `26.66% <33.33%> (ø)` | |
| [...ndler/QueryWebHookConfigByManufacturerHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvUXVlcnlXZWJIb29rQ29uZmlnQnlNYW51ZmFjdHVyZXJIYW5kbGVyLmphdmE=) | `22.22% <33.33%> (ø)` | |
| [...time/admin/handler/DeleteWebHookConfigHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRGVsZXRlV2ViSG9va0NvbmZpZ0hhbmRsZXIuamF2YQ==) | `26.66% <50.00%> (ø)` | |
| [...time/admin/handler/InsertWebHookConfigHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvSW5zZXJ0V2ViSG9va0NvbmZpZ0hhbmRsZXIuamF2YQ==) | `26.66% <50.00%> (ø)` | |
| [...time/admin/handler/UpdateWebHookConfigHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVXBkYXRlV2ViSG9va0NvbmZpZ0hhbmRsZXIuamF2YQ==) | `26.66% <50.00%> (ø)` | |
| [...pache/eventmesh/spi/EventMeshExtensionFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NwaS9FdmVudE1lc2hFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `53.84% <50.00%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2354/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #2354: reconstruct ClientManageController
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354#issuecomment-1334710465
@weihubeats please use the template for submit the pull request, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] weihubeats commented on pull request #2354: [Enhancement] reconstruct ClientManageController
Posted by GitBox <gi...@apache.org>.
weihubeats commented on PR #2354:
URL: https://github.com/apache/incubator-eventmesh/pull/2354#issuecomment-1334717677
Modified pr name, is that what it means?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org