You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/02/20 11:17:55 UTC

[GitHub] spark pull request #16999: [SPARK-18922][TESTS] Fix Windows new test failure...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16999#discussion_r101995600
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaRelationSuite.scala ---
    @@ -147,6 +148,9 @@ class KafkaRelationSuite extends QueryTest with BeforeAndAfter with SharedSQLCon
       }
     
       test("test late binding start offsets") {
    +    // Kafka fails to remove the logs on Windows. See KAFKA-1194.
    +    assume(!Utils.isWindows)
    +
    --- End diff --
    
    It seems we can't just ignore the deletion failure because it causes the test failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org