You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/12/27 04:17:31 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #1700: fix typos

chunweilei commented on a change in pull request #1700: fix typos
URL: https://github.com/apache/calcite/pull/1700#discussion_r361577607
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
 ##########
 @@ -1170,8 +1170,8 @@ private JoinOnLeftCalcToJoinUnifyRule() {
       final RexBuilder rexBuilder = call.getCluster().getRexBuilder();
 
       // Try pulling up MutableCalc only when:
-      // 1. it's inner join;
-      // 2. it's outer join but no filttering condition from MutableCalc.
+      // 1. it's inner join.
+      // 2. it's outer join but no filtering condition from MutableCalc.
       final JoinRelType joinRelType = sameJoinType(query.joinType, target.joinType);
 
 Review comment:
   This patch is small. Maybe we can merge it with others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services