You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/30 02:44:16 UTC
[GitHub] [shardingsphere] Ahoo-Wang opened a new pull request #14431: CosIdKeyGenerateAlgorithm support key of String type.
Ahoo-Wang opened a new pull request #14431:
URL: https://github.com/apache/shardingsphere/pull/14431
Fixes #14427 .
Changes proposed in this pull request:
`CosIdKeyGenerateAlgorithm` currently only supports generating `long` type keys. We want to support string type keys.
such as `266691111261569024` `JhRmZIPe3k` `20211229221515806-0-0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #14431: CosIdKeyGenerateAlgorithm support key of String type.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #14431:
URL: https://github.com/apache/shardingsphere/pull/14431#issuecomment-1002862196
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14431](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0ce94d) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6009c8b29b26ae5d69e182df0f61e97c7c371cac?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6009c8b) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14431 +/- ##
============================================
- Coverage 59.52% 59.48% -0.05%
- Complexity 1795 1796 +1
============================================
Files 2966 2969 +3
Lines 44030 44065 +35
Branches 7473 7482 +9
============================================
+ Hits 26211 26213 +2
- Misses 15784 15817 +33
Partials 2035 2035
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ng/algorithm/keygen/CosIdKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL2tleWdlbi9Db3NJZEtleUdlbmVyYXRlQWxnb3JpdGhtLmphdmE=) | `91.66% <100.00%> (+4.16%)` | :arrow_up: |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...pache/shardingsphere/traffic/rule/TrafficRule.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL3J1bGUvVHJhZmZpY1J1bGUuamF2YQ==) | `30.76% <0.00%> (-29.24%)` | :arrow_down: |
| [...e/traffic/api/config/TrafficRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYWZmaWMvYXBpL2NvbmZpZy9UcmFmZmljUnVsZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...apache/shardingsphere/infra/hint/SQLHintUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRVdGlscy5qYXZh) | `80.00% <0.00%> (ø)` | |
| [...lgorithm/traffic/hint/SQLHintTrafficAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2FsZ29yaXRobS90cmFmZmljL2hpbnQvU1FMSGludFRyYWZmaWNBbGdvcml0aG0uamF2YQ==) | `18.18% <0.00%> (ø)` | |
| [...loadbalance/RandomTrafficLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2FsZ29yaXRobS9sb2FkYmFsYW5jZS9SYW5kb21UcmFmZmljTG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `33.33% <0.00%> (ø)` | |
| [...he/shardingsphere/infra/hint/SQLHintExtractor.java](https://codecov.io/gh/apache/shardingsphere/pull/14431/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L1NRTEhpbnRFeHRyYWN0b3IuamF2YQ==) | `90.90% <0.00%> (+3.95%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6009c8b...e0ce94d](https://codecov.io/gh/apache/shardingsphere/pull/14431?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #14431: CosIdKeyGenerateAlgorithm support key of String type.
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #14431:
URL: https://github.com/apache/shardingsphere/pull/14431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org