[GitHub] [ignite-3] sanpwc commented on a change in pull request #502: IGNITE-15926 DDL methods for tables should throw an exception when th…

[GitBox <gi...@apache.org>]

sanpwc commented on a change in pull request #502:
URL: https://github.com/apache/ignite-3/pull/502#discussion_r768363681



##########
File path: modules/api/src/main/java/org/apache/ignite/table/manager/IgniteTables.java
##########
@@ -58,41 +59,12 @@
      */
     CompletableFuture<Table> createTableAsync(String name, Consumer<TableChange> tableInitChange);
 
-    /**
-     * Creates a new table with the given {@code name} or returns an existing one with the same {@code name}.
-     *
-     * <p>Note: the configuration of the existed table will NOT be validated against the given {@code tableInitChange}.
-     *
-     * @param name            Table name.
-     * @param tableInitChange Table changer.
-     * @return Existing or newly created table.
-     * @throws IgniteException If an unspecified platform exception has happened internally. Is thrown when:
-     *                         <ul>
-     *                             <li>the node is stopping.</li>
-     *                         </ul>
-     */
-    Table createTableIfNotExists(String name, Consumer<TableChange> tableInitChange);
-
-    /**
-     * Creates a new table with the given {@code name} or returns an existing one with the same {@code name}.
-     *
-     * <p>Note: the configuration of the existed table will NOT be validated against the given {@code tableInitChange}.
-     *
-     * @param name            Table name.
-     * @param tableInitChange Table changer.
-     * @return Future representing pending completion of the operation.
-     * @throws IgniteException If an unspecified platform exception has happened internally. Is thrown when:
-     *                         <ul>
-     *                             <li>the node is stopping.</li>
-     *                         </ul>
-     */
-    CompletableFuture<Table> createTableIfNotExistsAsync(String name, Consumer<TableChange> tableInitChange);
-
     /**
      * Alter a cluster table.
      *
      * @param name        Table name.
      * @param tableChange Table changer.
+     * @throws TableNotExistsException If a table with the name does not exist.

Review comment:
       Seems that in case of async methods TableNotExistsException isn't actually thrown, but used in order to complete the future, is that correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org