You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/11/08 08:55:15 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new issue, #1204: refactor: use CHECK* macros to replace assert macros
acelyc111 opened a new issue, #1204:
URL: https://github.com/apache/incubator-pegasus/issues/1204
This refactor work contains the following motivations:
1. macros are offen recommend to use all upper case.
2. the beginning char 'd' is easy to misunderstand as 'only enable in **D**ebug version'
3. there are 2 styles, `dassert_f` and `dassert`, we can unify them
- [x] replace dassert which check a single condition
- [x] replace dcheck_eq*
- [x] replace dcheck_ge*
- [x] replace dcheck_le*
- [x] replace dcheck_gt*
- [x] replace dcheck_lt*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 closed issue #1204: refactor: use CHECK* macros to replace assert macros
Posted by GitBox <gi...@apache.org>.
acelyc111 closed issue #1204: refactor: use CHECK* macros to replace assert macros
URL: https://github.com/apache/incubator-pegasus/issues/1204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on issue #1204: refactor: use CHECK* macros to replace assert macros
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on issue #1204:
URL: https://github.com/apache/incubator-pegasus/issues/1204#issuecomment-1306840875
## TODO
There are some code like
```
if (a) {
// do sth
} else {
CHECK(false, ...);
}
```
can be improved by
```
CHECK(a, ...)
// do sth
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org