You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Mike Percy (JIRA)" <ji...@apache.org> on 2012/11/15 20:35:12 UTC
[jira] [Created] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Mike Percy created FLUME-1713:
---------------------------------
Summary: Netcat source should allow for *not* returning "OK" upon receipt of each message
Key: FLUME-1713
URL: https://issues.apache.org/jira/browse/FLUME-1713
Project: Flume
Issue Type: Improvement
Reporter: Mike Percy
Priority: Minor
Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503599#comment-13503599 ]
Rahul Ravindran commented on FLUME-1713:
----------------------------------------
[~mpercy]: 1 and 2 done.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1713:
------------------------------
Component/s: Easy
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Reporter: Mike Percy
> Priority: Minor
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Ravindran updated FLUME-1713:
-----------------------------------
Attachment: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506319#comment-13506319 ]
Rahul Ravindran commented on FLUME-1713:
----------------------------------------
Is there any way to get a patch of this change for v1.3? We plan to deploy prior to 1.4, and I would really prefer not to build our own version of v1.3.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0, v1.3.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.4.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506592#comment-13506592 ]
Rahul Ravindran commented on FLUME-1713:
----------------------------------------
[~mpercy], I just joined the dev list and don't seem to be able to respond to an older thread. Would be thankful if you could bring this up in the 1.3 VOTE thread. I have sent a separate mail to the dev mailing list with the same request.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0, v1.3.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.4.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506344#comment-13506344 ]
Mike Percy commented on FLUME-1713:
-----------------------------------
FWIW I'm +1 on this low risk change if we decide to roll another RC but it's up to the RM.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0, v1.3.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.4.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502432#comment-13502432 ]
Mike Percy commented on FLUME-1713:
-----------------------------------
Rahul, thanks for the patch! In addition to posting to the Apache review board, please also:
1. Format your patch using "git diff" instead of "git format-patch".
2. Include a unit test to verify that the functionality works.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1713:
------------------------------
Affects Version/s: v1.3.0
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0, v1.3.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.4.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507005#comment-13507005 ]
Hudson commented on FLUME-1713:
-------------------------------
Integrated in flume-trunk #333 (See [https://builds.apache.org/job/flume-trunk/333/])
FLUME-1713. Netcat source should allow for *not* returning "OK" upon receipt of each message. (Revision e257e3db054d8a8282bfb14187f2dadf8e3c13e4)
Result = UNSTABLE
mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=e257e3db054d8a8282bfb14187f2dadf8e3c13e4
Files :
* flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java
* flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java
* flume-ng-core/src/main/java/org/apache/flume/source/NetcatSourceConfigurationConstants.java
* flume-ng-doc/sphinx/FlumeUserGuide.rst
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.3.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Percy updated FLUME-1713:
------------------------------
Affects Version/s: (was: v1.3.0)
Fix Version/s: (was: v1.4.0)
v1.3.0
Moving fixVersion to v1.3.0 since Brock backported this to the 1.3 release branch.
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.3.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-1713) Netcat source should allow for *not*
returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Ravindran updated FLUME-1713:
-----------------------------------
Attachment: final_patch.diff
Final patch after incorporating Mike's comments
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503598#comment-13503598 ]
Rahul Ravindran commented on FLUME-1713:
----------------------------------------
Review board url: https://reviews.apache.org/r/8220/
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Mike Percy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506343#comment-13506343 ]
Mike Percy commented on FLUME-1713:
-----------------------------------
Feel free to bring it up in the 1.3 VOTE thread on the Dev list
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0, v1.3.0
> Reporter: Mike Percy
> Assignee: Rahul Ravindran
> Priority: Minor
> Labels: newbie
> Fix For: v1.4.0
>
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch, final_patch.diff
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Rahul Ravindran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502423#comment-13502423 ]
Rahul Ravindran commented on FLUME-1713:
----------------------------------------
Review board id:https://review.cloudera.org/r/2462/
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1713) Netcat source should allow for
*not* returning "OK" upon receipt of each message
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502429#comment-13502429 ]
Hari Shreedharan commented on FLUME-1713:
-----------------------------------------
[~rahulrv] We use Apache Review Board for reviews. Please post the review on https://reviews.apache.org
> Netcat source should allow for *not* returning "OK" upon receipt of each message
> --------------------------------------------------------------------------------
>
> Key: FLUME-1713
> URL: https://issues.apache.org/jira/browse/FLUME-1713
> Project: Flume
> Issue Type: Improvement
> Components: Easy
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Priority: Minor
> Labels: newbie
> Attachments: 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In reality, this means that using netcat to send to the "Netcat source" will in most cases not work as expected. It will stall out if the responses are not read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira