You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/18 03:01:12 UTC

[GitHub] [arrow-rs] waitingkuo opened a new issue, #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api

waitingkuo opened a new issue, #3131:
URL: https://github.com/apache/arrow-rs/issues/3131

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   add/sub months was originally only implemented in chrono's NaiveDate
   
   a custom shift_months was implemented by @avantgardnerio to support NaiveDatetime
   https://github.com/apache/arrow-rs/blob/master/arrow-array/src/delta.rs#L50-L82
   
   as chronos 0.4.23 is out, add/sub now supports NaiveDatetime as well
   
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   replace the custom logic by chrono's
   
   
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3131:
URL: https://github.com/apache/arrow-rs/issues/3131#issuecomment-1327307714

   `label_issue.py` automatically added labels {'arrow'} from #3132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api
URL: https://github.com/apache/arrow-rs/issues/3131


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3131:
URL: https://github.com/apache/arrow-rs/issues/3131#issuecomment-1327307693

   `label_issue.py` automatically added labels {'parquet'} from #3132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #3131: Replace custom date/time add/sub months by chrono 0.4.23's new api

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3131:
URL: https://github.com/apache/arrow-rs/issues/3131#issuecomment-1327307736

   `label_issue.py` automatically added labels {'object-store'} from #3132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org