You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jim Kellerman (JIRA)" <ji...@apache.org> on 2008/09/07 10:11:44 UTC
[jira] Created: (HBASE-876) There are a large number of Java
warnings in HBase
There are a large number of Java warnings in HBase
--------------------------------------------------
Key: HBASE-876
URL: https://issues.apache.org/jira/browse/HBASE-876
Project: Hadoop HBase
Issue Type: Bug
Affects Versions: 0.18.0
Reporter: Jim Kellerman
Assignee: Jim Kellerman
Priority: Minor
Fix For: 0.19.0
There are a large number of Java warnings in the current HBase code base including:
- exceptions that do not define serialVersionUID
- classes that use the raw type WritableComparable instead of WritableComparable<T>
- classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
- methods that have unnecessary else clauses
- potential null pointer access
- inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
- assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-876:
------------------------
Fix Version/s: (was: 0.19.0)
0.20.0
Moving out of 0.19.0.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_1.patch
First patch that fixes all warning in package:
org.apache.hadoop.hbase
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629034#action_12629034 ]
Jim Kellerman commented on HBASE-876:
-------------------------------------
Yes, I am talking about eclipse warnings.
I was hoping that eventually we could start running findbugs on Hudson as Hadoop does. But running it locally, and fixing those along with what eclipse complains about would certainly be a good thing.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.19.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_8.patch
876_8.patch is for:
org.apache.hadoop.hbase.thrift
org.apache.hadoop.hbase.util
org.onelab.filter
The last one.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch, 876_7.patch, 876_8.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-876 started by Evgeny Ryabitskiy.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_5.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629016#action_12629016 ]
stack commented on HBASE-876:
-----------------------------
Are you talking about eclipse warnings? You think we should run findbugs or some of the other tools against code base? Might find more substantial issues?
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Jim Kellerman
> Priority: Minor
> Fix For: 0.19.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: (was: 876_2.patch)
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_4.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662676#action_12662676 ]
stack commented on HBASE-876:
-----------------------------
Agree that per package is way to go. I won't apply till we branch 0.19... shouldn't be long
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_2.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666053#action_12666053 ]
stack commented on HBASE-876:
-----------------------------
I didn't apply fixup for ipc package Evgeny. These too are copied down from hadoop and the less differences the better. Otherwise all others look good. Testing now.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch, 876_7.patch, 876_8.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_2.patch
876_2.patch is for packages:
org.apache.hadoop.hbase.client
org.apache.hadoop.hbase.client.tableindexed
org.apache.hadoop.hbase.client.transactional
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-876) There are a large number
of Java warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662659#action_12662659 ]
apparition edited comment on HBASE-876 at 1/10/09 4:21 PM:
------------------------------------------------------------------
876_1.patch fixes all warnings in package:
org.apache.hadoop.hbase
was (Author: apparition):
First patch that fixes all warning in package:
org.apache.hadoop.hbase
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665559#action_12665559 ]
Evgeny Ryabitskiy commented on HBASE-876:
-----------------------------------------
876_4.patch is for:
org.apache.hadoop.hbase.ipc
876_5.patch is for:
org.apache.hadoop.hbase.mapred
876_6.patch is for:
org.apache.hadoop.hbase.master
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: (was: 876_1.patch)
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-876) There are a large number
of Java warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662698#action_12662698 ]
apparition edited comment on HBASE-876 at 1/10/09 4:20 PM:
------------------------------------------------------------------
876_2.patch is for packages:
org.apache.hadoop.hbase.client
org.apache.hadoop.hbase.client.tableindexed
org.apache.hadoop.hbase.client.transactional
org.apache.hadoop.hbase.filter
was (Author: apparition):
876_2.patch is for packages:
org.apache.hadoop.hbase.client
org.apache.hadoop.hbase.client.tableindexed
org.apache.hadoop.hbase.client.transactional
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665348#action_12665348 ]
stack commented on HBASE-876:
-----------------------------
I applied parts 1, 2, and 3. I left out changes to SequenceFile and MapFile from part 3 since they are from hadoop itself and we don't want to change these since it'll make it harder going forward ensuring we pick up changes that have happened in parent versions (these should be going away soon in next version or so of hbase anyways).
Thanks Evgeny for the great cleanup. Do you have more? If not, I'll close the issue.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_6.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662661#action_12662661 ]
Evgeny Ryabitskiy commented on HBASE-876:
-----------------------------------------
I decide to fixing warnings by package, so there will be one patch per each package. I think it's a best way to make so much changes.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_1.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_3.patch
876_3.patch is for package:
org.apache.hadoop.hbase.io
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: (was: 876_5.patch)
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_7.patch
876_7.patch is for:
org.apache.hadoop.hbase.master.metrics
org.apache.hadoop.hbase.metrics.file
org.apache.hadoop.hbase.regionserver
org.apache.hadoop.hbase.regionserver.metrics
org.apache.hadoop.hbase.regionserver.tableindexed
org.apache.hadoop.hbase.regionserver.transactional
org.apache.hadoop.hbase.rest
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch, 876_7.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: (was: 876_2.patch)
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662594#action_12662594 ]
Evgeny Ryabitskiy commented on HBASE-876:
-----------------------------------------
So now I am fighting with warnings. There already more than 100 left. And my patch will affect on almost every source java file :)
I am also fighting with warnings for Annotations like this:
- Unnecessary @SuppressWarnings("unused")
There still warnings like this:
- Access to enclosing method "myMethod" from the type "myClass" is emulated by a synthetic accessor method. Increasing its visibility will improve your performance
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy reassigned HBASE-876:
---------------------------------------
Assignee: Evgeny Ryabitskiy (was: Jim Kellerman)
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662599#action_12662599 ]
stack commented on HBASE-876:
-----------------------------
Evgeny:
I noticed that when I went from 3.3 eclipse to 3.4 (ganymede), it started saying 'Unnecessary @SuppressWarnings("unused")' are unnecessary. You are using ganymede eclipse? I'd say remove them.
On second warning type, I suppose we should do as suggested.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "Evgeny Ryabitskiy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Evgeny Ryabitskiy updated HBASE-876:
------------------------------------
Attachment: 876_2.patch
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-876) There are a large number of Java
warnings in HBase
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-876.
-------------------------
Resolution: Fixed
Committed. Thank you for the patch Evgeny.
> There are a large number of Java warnings in HBase
> --------------------------------------------------
>
> Key: HBASE-876
> URL: https://issues.apache.org/jira/browse/HBASE-876
> Project: Hadoop HBase
> Issue Type: Bug
> Affects Versions: 0.18.0
> Reporter: Jim Kellerman
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: 876_1.patch, 876_2.patch, 876_3.patch, 876_4.patch, 876_5.patch, 876_6.patch, 876_7.patch, 876_8.patch
>
>
> There are a large number of Java warnings in the current HBase code base including:
> - exceptions that do not define serialVersionUID
> - classes that use the raw type WritableComparable instead of WritableComparable<T>
> - classes or interfaces that declare public members that are not a part of the public API. In this case they should be moved to a place where their visibility needs not be public. Additionally, there are a number of classes that declare public members that need not be. Make them protected or private or default as needed
> - methods that have unnecessary else clauses
> - potential null pointer access
> - inner classes that are public that should be default or protected (e.g. RegionHistoryInformation)
> - assignment to an input parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.