You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/11 11:01:04 UTC

[jira] [Commented] (FLINK-6351) Refactor YarnFlinkApplicationMasterRunner by combining AbstractYarnFlinkApplicationMasterRunner in one class

    [ https://issues.apache.org/jira/browse/FLINK-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006237#comment-16006237 ] 

ASF GitHub Bot commented on FLINK-6351:
---------------------------------------

Github user shuai-xu commented on the issue:

    https://github.com/apache/flink/pull/3755
  
    There will soon be a YarnFlinkAppMaster extends AbstractYarnFlinkApplicationMasterRunner for flink yarn cluster mode, so need not combine them to one class.


> Refactor YarnFlinkApplicationMasterRunner by combining AbstractYarnFlinkApplicationMasterRunner in one class
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6351
>                 URL: https://issues.apache.org/jira/browse/FLINK-6351
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: mingleizhang
>            Assignee: mingleizhang
>
> The currently YarnFlinkApplicationMasterRunner inherits from AbstractYarnFlinkApplicationMasterRunner and seems a bit unnecessary. We could conbine two classes and then instantiate the services and runtime components in the constructor of YarnFlinkApplicationMasterRunner for getting rid of the lock in run method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)