You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/09/27 21:28:45 UTC

[kudu-CR] [rpc] KUDU-3514 add metric to track per-RPC timeouts

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20517


Change subject: [rpc] KUDU-3514 add metric to track per-RPC timeouts
......................................................................

[rpc] KUDU-3514 add metric to track per-RPC timeouts

This patch introduces a new per-RPC counter to accumulate stats on the
responses that have been sent to the client side past the deadline.
It should help troubleshooting of particular scenarios and provide
a glimpse of what part of requests to a particular RPC method timed out
while being processed.

This patch also includes test scenarios to cover the functionality
of the newly introduced metric.

Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/service_if.h
5 files changed, 222 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/20517/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Gerrit-Change-Number: 20517
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [rpc] KUDU-3514 add metric to track per-RPC timeouts

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20517

to look at the new patch set (#2).

Change subject: [rpc] KUDU-3514 add metric to track per-RPC timeouts
......................................................................

[rpc] KUDU-3514 add metric to track per-RPC timeouts

This patch introduces a new per-RPC counter to accumulate stats on the
responses that have been sent to the client side past the deadline.
It should help troubleshooting of particular scenarios and provide
a glimpse of what part of requests to a particular RPC method timed out
while being processed.

This patch also includes test scenarios to cover the functionality
of the newly introduced metric.

Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/service_if.h
5 files changed, 216 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/20517/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Gerrit-Change-Number: 20517
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [rpc] KUDU-3514 add metric to track per-RPC timeouts

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20517 )

Change subject: [rpc] KUDU-3514 add metric to track per-RPC timeouts
......................................................................

[rpc] KUDU-3514 add metric to track per-RPC timeouts

This patch introduces a new per-RPC counter to accumulate stats on the
responses that have been sent to the client side past the deadline.
It should help troubleshooting of particular scenarios and provide
a glimpse of what part of requests to a particular RPC method timed out
while being processed.

This patch also includes test scenarios to cover the functionality
of the newly introduced metric.

Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Reviewed-on: http://gerrit.cloudera.org:8080/20517
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/service_if.h
5 files changed, 216 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Martonka: Looks good to me, but someone else must approve
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/20517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Gerrit-Change-Number: 20517
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [rpc] KUDU-3514 add metric to track per-RPC timeouts

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20517 )

Change subject: [rpc] KUDU-3514 add metric to track per-RPC timeouts
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Gerrit-Change-Number: 20517
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2023 06:49:23 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] KUDU-3514 add metric to track per-RPC timeouts

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20517 )

Change subject: [rpc] KUDU-3514 add metric to track per-RPC timeouts
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a3cef63475c26f7936d5be7a0072a72332b7c88
Gerrit-Change-Number: 20517
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2023 17:18:13 +0000
Gerrit-HasComments: No