[jira] [Commented] (ZOOKEEPER-2498) Potential resource leak in C client when processing unexpected / out of order response

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405347#comment-15405347 ] 

Hadoop QA commented on ZOOKEEPER-2498:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12821771/ZOOKEEPER-2498.patch
  against trunk revision 1754582.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3320//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3320//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3320//console

This message is automatically generated.

> Potential resource leak in C client when processing unexpected / out of order response
> --------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2498
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2498
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.8, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>             Fix For: 3.4.9, 3.5.3
>
>         Attachments: ZOOKEEPER-2498.patch
>
>
> In C client, we use reference counting to decide if a given zh handle can be destroyed or not. This requires we always make sure to call api_prolog (which increment the counter) and api_epilog (which decrease the counter) in pairs, for a given call context. 
> In zookeeper_process, there is a place where the code will return without invoking api_epilog, which would lead to potential zh resource leak.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)