You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2007/07/06 19:37:32 UTC

[VOTE] disable line-precise error reporting by default

the new error reporting feature, that one that throws two exceptions per
component, is really making development not enjoyable. it slows down request
processing significantly and might give noobs the wrong impression. it is
valuable information for noobs, but imho after using wicket for a week you
will probably encounter such problems rarely.

[ ] disable this feature by default, put instructions on how to enable it
into component-not-found related exception messages
[ ] leave it enabled by default

-igor

Re: [VOTE] disable line-precise error reporting by default

Posted by Eelco Hillenius <ee...@gmail.com>.
>  * provide link to switch it on on exception page

Nice idea!

Eelco

Re: [VOTE] disable line-precise error reporting by default

Posted by Martijn Dashorst <ma...@gmail.com>.
Killed long argument

Summary:
 * disable it in development profile, but turn it on in
quickstart#init with comment
 * provide link to switch it on on exception page
 * add debug profile
 * switch markup location to 'on' in development mode
 * add Java based profiles, with non-deprecated web.xml init parameters [1]
 * add Wicket development mode dashboard to development mode visible
on all pages
 * add deployment profile to quickstart pom that switches web.xml to
deployment mode

[1] the web.xml settings provide a great opportunity to create a war
based on profiles using filtering with Maven and Ant.

Martijn

On 7/6/07, Igor Vaynberg <ig...@gmail.com> wrote:
> the new error reporting feature, that one that throws two exceptions per
> component, is really making development not enjoyable. it slows down request
> processing significantly and might give noobs the wrong impression. it is
> valuable information for noobs, but imho after using wicket for a week you
> will probably encounter such problems rarely.
>
> [ ] disable this feature by default, put instructions on how to enable it
> into component-not-found related exception messages
> [ ] leave it enabled by default
>
> -igor
>


-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Apache Wicket 1.3.0-beta2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta2/

Re: [VOTE] disable line-precise error reporting by default

Posted by Juergen Donnerstag <ju...@gmail.com>.
[x] disable this feature by default, put instructions on how to enable it

Juergen

Re: [VOTE] disable line-precise error reporting by default

Posted by Igor Vaynberg <ig...@gmail.com>.
On 7/6/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> [x] disable this feature by default, put instructions on how to enable it
> into component-not-found related exception messages
> [ ] leave it enabled by default
>
> -igor
>
>

Re: [VOTE] disable line-precise error reporting by default

Posted by Al Maw <wi...@almaw.com>.
Igor Vaynberg wrote:
> [x] disable this feature by default, put instructions on how to enable it
> into component-not-found related exception messages
> [ ] leave it enabled by default

Debug performance without this option is sufficiently close to 
production (this would being it within the same order of magnitude!) 
that I'm not fussed by the other things.

Regards,

Al

-- 
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Re: [VOTE] disable line-precise error reporting by default

Posted by Jonathan Locke <jo...@gmail.com>.

 [ x ] disable this feature by default, put instructions on how to enable it
 into component-not-found related exception messages
 [ ] leave it enabled by default

i like the idea of a debug deployment mode.  if we get into profiles, i'd
prefer it be kept in code and not introduce any kind of data store
(particularly
XML) for this.  each deployment mode could just be a subclass of an
AbstractDeployment base class which basically takes a Settings object 
and configures it.  then picking your deployment would just be a matter
of giving the deployment class you want to start with (the current string 
based configure method would be deprecated but select the right deployment
class for compatibility).


Eelco Hillenius wrote:
> 
>  [ x ] disable this feature by default, put instructions on how to enable
> it
>  into component-not-found related exception messages
>  [ ] leave it enabled by default
> 
> I've argued before that if it were up to me, deployment would be our
> default. Lost that argument and that is fine, but I feel that debug
> options such as there can give people the wrong ideas.
> 
> One thing we might consider is to add a third deployment mode -
> something like DEBUG - which would include this setting and e.g. the
> outputMarkupClass setting[1] (which is a very useful tool that is
> turned off by default). And/ or we could consider to have plugable
> profiles rather than the two hard-coded ones.
> 
> Eelco
> 
> [1]
> http://chillenious.wordpress.com/2007/06/20/locate-where-that-wicket-markup-comes-from/
> 
> 

-- 
View this message in context: http://www.nabble.com/-VOTE--disable-line-precise-error-reporting-by-default-tf4037146.html#a11475042
Sent from the Wicket - Dev mailing list archive at Nabble.com.


Re: [VOTE] disable line-precise error reporting by default

Posted by Eelco Hillenius <ee...@gmail.com>.
 [ x ] disable this feature by default, put instructions on how to enable it
 into component-not-found related exception messages
 [ ] leave it enabled by default

I've argued before that if it were up to me, deployment would be our
default. Lost that argument and that is fine, but I feel that debug
options such as there can give people the wrong ideas.

One thing we might consider is to add a third deployment mode -
something like DEBUG - which would include this setting and e.g. the
outputMarkupClass setting[1] (which is a very useful tool that is
turned off by default). And/ or we could consider to have plugable
profiles rather than the two hard-coded ones.

Eelco

[1] http://chillenious.wordpress.com/2007/06/20/locate-where-that-wicket-markup-comes-from/

Re: [VOTE] disable line-precise error reporting by default

Posted by Martijn Dashorst <ma...@gmail.com>.
Just having gotten my head above the water after looking at some
pretty fishies I don't mind.

Martijn

On 8/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> On 8/8/07, Janne Hietamäki <ja...@apache.org> wrote:
> >
> >
> > On Jul 6, 2007, at 8:37 PM, Igor Vaynberg wrote:
> >
> > > the new error reporting feature, that one that throws two
> > > exceptions per
> > > component, is really making development not enjoyable. it slows
> > > down request
> > > processing significantly and might give noobs the wrong impression.
> > > it is
> > > valuable information for noobs, but imho after using wicket for a
> > > week you
> > > will probably encounter such problems rarely.
> > >
> > > [x] disable this feature by default, put instructions on how to
> > > enable it
> > > into component-not-found related exception messages
> > > [ ] leave it enabled by default
> > >
> > > -igor
> >
> > Ping!
>
>
> there is a jira issue and it is assigned to martijn. if you want to take it
> over im sure he wont mind.
>
> -igor
>
>
> Janne
> >
> >
>


-- 
Wicket joins the Apache Software Foundation as Apache Wicket
Apache Wicket 1.3.0-beta2 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta2/

Re: [VOTE] disable line-precise error reporting by default

Posted by Igor Vaynberg <ig...@gmail.com>.
On 8/8/07, Janne Hietamäki <ja...@apache.org> wrote:
>
>
> On Jul 6, 2007, at 8:37 PM, Igor Vaynberg wrote:
>
> > the new error reporting feature, that one that throws two
> > exceptions per
> > component, is really making development not enjoyable. it slows
> > down request
> > processing significantly and might give noobs the wrong impression.
> > it is
> > valuable information for noobs, but imho after using wicket for a
> > week you
> > will probably encounter such problems rarely.
> >
> > [x] disable this feature by default, put instructions on how to
> > enable it
> > into component-not-found related exception messages
> > [ ] leave it enabled by default
> >
> > -igor
>
> Ping!


there is a jira issue and it is assigned to martijn. if you want to take it
over im sure he wont mind.

-igor


Janne
>
>

Re: [VOTE] disable line-precise error reporting by default

Posted by Janne Hietamäki <ja...@apache.org>.
On Jul 6, 2007, at 8:37 PM, Igor Vaynberg wrote:

> the new error reporting feature, that one that throws two  
> exceptions per
> component, is really making development not enjoyable. it slows  
> down request
> processing significantly and might give noobs the wrong impression.  
> it is
> valuable information for noobs, but imho after using wicket for a  
> week you
> will probably encounter such problems rarely.
>
> [x] disable this feature by default, put instructions on how to  
> enable it
> into component-not-found related exception messages
> [ ] leave it enabled by default
>
> -igor

Ping!



Janne