[jira] [Resolved] (WICKET-4053) AbstractTree#updateTree(AjaxRequestTarget target) is invoked even when request is non-ajax

["Peter Ertl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl resolved WICKET-4053.
--------------------------------

    Resolution: Fixed

> AbstractTree#updateTree(AjaxRequestTarget target) is invoked even when request is non-ajax
> ------------------------------------------------------------------------------------------
>
>                 Key: WICKET-4053
>                 URL: https://issues.apache.org/jira/browse/WICKET-4053
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.0
>         Environment: Wicket 1.5.0
>            Reporter: James McIntosh
>            Assignee: Peter Ertl
>             Fix For: 1.5.1
>
>
> I came across an issue when trying to get Brix working in wicket 1.5.
> It occurs when the Tree has: setLinkType(LinkType.REGULAR);
> Caused by: java.lang.IllegalArgumentException: Argument 'target' may not be null.
> 	at org.apache.wicket.util.lang.Args.notNull(Args.java:39)
> 	at org.apache.wicket.markup.html.tree.AbstractTree.updateTree(AbstractTree.java:1138)
> 	at org.apache.wicket.markup.html.tree.LinkIconPanel.onNodeLinkClicked(LinkIconPanel.java:82)
> 	at org.apache.wicket.markup.html.tree.LinkIconPanel$1.onClick(LinkIconPanel.java:59)
> 	at org.apache.wicket.markup.html.tree.BaseTree$5.onClick(BaseTree.java:386)
> 	at org.apache.wicket.markup.html.link.Link.onLinkClicked(Link.java:187)
> I only had a quick search across the wicket codebase to see if this method is called elsewhere
> To fix LinkIconPanel line 82 should be
> if (target != null) {
> tree.updateTree(target);
> }
> BaseTree - line 294 also calls updateTree(target) with no null check.
> 	
> 	

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira