You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/07/08 18:29:17 UTC

[GitHub] [avro] tjwp commented on pull request #928: AVRO-2382: Fix VERSION constant for Ruby gem

tjwp commented on pull request #928:
URL: https://github.com/apache/avro/pull/928#issuecomment-655683749


   Thanks for the review Ryan!
   
   I went with this approach over a search-and-replace because it did not require a change to a file under version control whenever the release version changes while also ensuring that it always gets the correct version.
   
   If we had and automated search-and-replace process over the entire repo then I'd definitely go with hooking the Ruby build into that and would probably replace the version directly in the `lib/avro.rb` file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org