You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@otava.apache.org by "Gerrrr (via GitHub)" <gi...@apache.org> on 2026/06/08 02:31:01 UTC
[PR] Use independent parameters for Otava algorithms [otava-playground]
Gerrrr opened a new pull request, #6:
URL: https://github.com/apache/otava-playground/pull/6
In https://github.com/apache/otava/pull/154, @henrikingo mentioned that using the same P-value for all 3 algorithms is not a fair comparison.
> The deterministic variant finds much less change points for the
> same p-values. It is closer to original edivisive in behavior than to
> the hunter variant. To some extent this is a matter of perspective
too: Who's to say we should compare them with constant p-values
This patch allows setting P-values independently for all 3 algorithms. It also "boxes" window size to the split algorithm, which may be a more intuitive UX for new users.
<img width="467" height="405" alt="Screenshot 2026-06-07 at 7 30 39 PM" src="https://github.com/user-attachments/assets/449e1de9-bbc0-4cb3-b3fe-031112dfe37c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use independent parameters for Otava algorithms [otava-playground]
Posted by "Gerrrr (via GitHub)" <gi...@apache.org>.
Gerrrr merged PR #6:
URL: https://github.com/apache/otava-playground/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org