You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/20 15:48:01 UTC
[native-toolchain-CR] Add documentation for docker-related toolchain builds
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12810
Change subject: Add documentation for docker-related toolchain builds
......................................................................
Add documentation for docker-related toolchain builds
This commit adds basic documentation with regard to docker-based
toolchain builds. It breifly outlines how to build images and how to use
them to build the toolchain. I also added the ability to fetch images
from a docker registry. And fixed an 'undefined' variable problem with
docker-based builds.
Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
---
M Makefile
A docker/README.md
M functions.sh
3 files changed, 52 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/12810/1
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-based toolchain builds
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@7
PS1, Line 7: based t
> maybe "based" ?
Done
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@10
PS1, Line 10: ie
> nit: typo
Done
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md
File docker/README.md:
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@18
PS1, Line 18: committe
> typo: committed
Done
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@26
PS1, Line 26: ubunt
> typo: ubuntu
Done
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@35
PS1, Line 35: it is possible to specify urls in the DISTROS
: make variable.
> Does this mean that specifying this URL would cause the Docker images to be
Roughly yes. Except that right now, the Makefile assumes that the images have already been built (if the images do not exist, the build procedure fails.)
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 17:14:30 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-based toolchain builds
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 17:22:36 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-based toolchain builds
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 20:19:20 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Add documentation for docker-related toolchain builds
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-related toolchain builds
......................................................................
Patch Set 1:
(6 comments)
Thanks for providing a description for the new build mechanism!
I have a few nits (typos and copy editing), with one location that wasn't completely clear to me.
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@7
PS1, Line 7: related
maybe "based" ?
http://gerrit.cloudera.org:8080/#/c/12810/1//COMMIT_MSG@10
PS1, Line 10: ei
nit: typo
http://gerrit.cloudera.org:8080/#/c/12810/1/Makefile
File Makefile:
http://gerrit.cloudera.org:8080/#/c/12810/1/Makefile@19
PS1, Line 19: debian8 \
nit: Usually we prefer spaces to tabs
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md
File docker/README.md:
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@18
PS1, Line 18: commited
typo: committed
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@26
PS1, Line 26: ubunu
typo: ubuntu
http://gerrit.cloudera.org:8080/#/c/12810/1/docker/README.md@35
PS1, Line 35: it is possible to specify urls in the DISTROS
: make variable.
Does this mean that specifying this URL would cause the Docker images to be fetched from the given registry (instead of building the containers)?
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 16:40:13 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12810 )
Change subject: Add documentation for docker-based toolchain builds
......................................................................
Add documentation for docker-based toolchain builds
This commit adds basic documentation with regard to docker-based
toolchain builds. It briefly outlines how to build images and how to use
them to build the toolchain. I also added the ability to fetch images
from a docker registry. And fixed an 'undefined' variable problem with
docker-based builds.
Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Reviewed-on: http://gerrit.cloudera.org:8080/12810
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Tested-by: Thomas Marshall <tm...@cloudera.com>
---
M Makefile
A docker/README.md
M functions.sh
3 files changed, 52 insertions(+), 5 deletions(-)
Approvals:
Thomas Marshall: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[native-toolchain-CR] Add documentation for docker-based toolchain builds
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hello Thomas Marshall, Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12810
to look at the new patch set (#2).
Change subject: Add documentation for docker-based toolchain builds
......................................................................
Add documentation for docker-based toolchain builds
This commit adds basic documentation with regard to docker-based
toolchain builds. It briefly outlines how to build images and how to use
them to build the toolchain. I also added the ability to fetch images
from a docker registry. And fixed an 'undefined' variable problem with
docker-based builds.
Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
---
M Makefile
A docker/README.md
M functions.sh
3 files changed, 52 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/10/12810/2
--
To view, visit http://gerrit.cloudera.org:8080/12810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id971bda58d537fa15ec63004f744d3f730bad170
Gerrit-Change-Number: 12810
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>