You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/11 13:17:21 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7077: server: fix cannot update vm if it uses unconstraint dynamic offering

weizhouapache commented on code in PR #7077:
URL: https://github.com/apache/cloudstack/pull/7077#discussion_r1066981323


##########
engine/schema/src/main/java/com/cloud/service/ServiceOfferingVO.java:
##########
@@ -327,7 +327,7 @@ public void setDynamicFlag(boolean isdynamic) {
     }
 
     public boolean isCustomCpuSpeedSupported() {
-        return isCustomized() && getDetail("minCPU") != null;
+        return isCustomized() && getDetail("minCPU") == null;

Review Comment:
   good, thanks @shwstppr 
   committed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org