[GitHub] [incubator-druid] gianm commented on a change in pull request #8388: Use Codecov

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #8388: Use Codecov
URL: https://github.com/apache/incubator-druid/pull/8388#discussion_r318287859
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -115,6 +115,9 @@ matrix:
           ${MAVEN_SKIP} -Dremoteresources.skip=true
         - sh -c "dmesg | egrep -i '(oom|out of memory|kill process|killed).*' -C 1 || exit 0"
         - free -m
+      after_success: &upload_java_unit_test_coverage
+        - ${MVN} -pl ${MAVEN_PROJECTS} jacoco:report
+        - travis_retry bash <(curl -s https://codecov.io/bash) -X gcov  # retry in case of network error
 
 Review comment:
   I think that `bash` here will run even if curl dies with an error, even in `-e` mode. I'd be more comfortable if this line was split up to prevent that from happening.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org