You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/02/05 15:23:43 UTC

svn commit: r1728672 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java

Author: markt
Date: Fri Feb  5 14:23:43 2016
New Revision: 1728672

URL: http://svn.apache.org/viewvc?rev=1728672&view=rev
Log:
Prevent NPEs on some error conditions.

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java?rev=1728672&r1=1728671&r2=1728672&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java Fri Feb  5 14:23:43 2016
@@ -418,11 +418,11 @@ public class Registry implements Registr
      */
     public void unregisterComponent( ObjectName oname ) {
         try {
-            if( getMBeanServer().isRegistered(oname)) {
+            if (oname != null && getMBeanServer().isRegistered(oname)) {
                 getMBeanServer().unregisterMBean(oname);
             }
-        } catch( Throwable t ) {
-            log.error( "Error unregistering mbean ", t);
+        } catch (Throwable t) {
+            log.error("Error unregistering mbean", t);
         }
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org