You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/24 10:01:38 UTC
[GitHub] [incubator-doris] yiguolei opened a new pull request, #9195: [Improvement] not print logs to fe.out when fe is running under daemon
yiguolei opened a new pull request, #9195:
URL: https://github.com/apache/incubator-doris/pull/9195
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#discussion_r857148098
##########
be/src/common/status.h:
##########
@@ -22,7 +22,7 @@ namespace doris {
// ErrorName, ErrorCode, String Description, Should print stacktrace
#define APPLY_FOR_ERROR_CODES(M) \
- M(OLAP_SUCCESS, 0, "", true) \
+ M(OLAP_SUCCESS, 0, "", false) \
Review Comment:
Because we don't need to print stack trace for `OLAP_SUCCESS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#issuecomment-1107871594
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#issuecomment-1107871615
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangshuo128 commented on a diff in pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
wangshuo128 commented on code in PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#discussion_r857115090
##########
be/src/common/status.h:
##########
@@ -22,7 +22,7 @@ namespace doris {
// ErrorName, ErrorCode, String Description, Should print stacktrace
#define APPLY_FOR_ERROR_CODES(M) \
- M(OLAP_SUCCESS, 0, "", true) \
+ M(OLAP_SUCCESS, 0, "", false) \
Review Comment:
Why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#issuecomment-1107871588
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Toms1999 commented on pull request #9195: [Improvement] not print logs to fe.out when fe is running under daemon
Posted by GitBox <gi...@apache.org>.
Toms1999 commented on PR #9195:
URL: https://github.com/apache/incubator-doris/pull/9195#issuecomment-1108136923
let me seesee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org