You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/10 23:19:53 UTC
[GitHub] [maven-scm] elharo opened a new pull request #101: [SCM-937] replace deprecated methods
elharo opened a new pull request #101:
URL: https://github.com/apache/maven-scm/pull/101
@eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626623296
This cannot be real: C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit
Writing into `C:\Windows` is just wrong. I have this dir on my machine: `C:\WINDOWS\System32\config\systemprofile\AppData`. It seems like Jenkins runs a some system account
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#discussion_r422948794
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java
##########
@@ -52,7 +53,8 @@
{
GitStatusConsumer consumer = new GitStatusConsumer( new DefaultLog(), null, relativeRepoPath );
- try ( BufferedReader r = new BufferedReader( new FileReader( gitlog ) ) )
+ try ( BufferedReader r = new BufferedReader(
+ new InputStreamReader ( new FileInputStream( gitlog ), StandardCharsets.UTF_8 ) ) )
Review comment:
I don't know whether this is better. If we read from stdin or the stdin has been redirected and the encoding was not UTF-8 and did contain multibyte characters the reader will show errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] elharo commented on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626622170
Seeing some flakiness in our windows builds for this plugin in multiple PRs:
Error Message
Command failed.The svn tag command failed.
Stacktrace
org.apache.maven.plugin.MojoExecutionException: Command failed.The svn tag command failed.
at org.apache.maven.scm.plugin.TagMojoTest.testTag(TagMojoTest.java:93)
Standard Output
Test command line: cmd.exe /X /C "svnadmin create repository"
[INFO] Removing F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[INFO] Executing: cmd.exe /X /C "svn --non-interactive checkout file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/trunk@ F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout"
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target
[INFO] Final Tag Name: 'mytag'
[INFO] Executing: cmd.exe /X /C "svn --non-interactive copy --file C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit --encoding UTF-8 --parents . file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/tags/mytag@"
[INFO] Executing: cmd.exe /X /C "svn --non-interactive copy --file C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit --encoding UTF-8 --parents . file:///F:/jenkins/jenkins-slave/workspace/maven-box_maven-scm_i937/m/maven-scm-plugin/target/repository/tags/mytag@"
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[INFO] Working directory: F:\jenkins\jenkins-slave\workspace\maven-box_maven-scm_i937\m\maven-scm-plugin\target\checkout
[ERROR] Provider message:
[ERROR] The svn tag command failed.
[ERROR] Command output:
[ERROR] svn: E720003: Can't open file 'C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit': The system cannot find the path specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] elharo commented on a change in pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#discussion_r422946097
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java
##########
@@ -52,9 +52,7 @@
{
GitStatusConsumer consumer = new GitStatusConsumer( new DefaultLog(), null, relativeRepoPath );
- BufferedReader r = new BufferedReader( new FileReader( gitlog ) );
-
- try
+ try ( BufferedReader r = new BufferedReader( new FileReader( gitlog ) ) )
Review comment:
good point. fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626641175
>
>
> #99 to update Plexus didn't flake, so possibly the plexus-utils update there fixes this?
I don't think. It might be node specific that `Temp` does exist. I would still inquire with INFRA first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o edited a comment on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626623296
This cannot be real: C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit
Writing into `C:\Windows` is just wrong. I have this dir on my machine: `C:\WINDOWS\System32\config\systemprofile\AppData`. It seems like Jenkins runs a some system account. `Temp` does not exist.
There it is: https://superuser.com/a/598626
We need to file an issue with INFRA to create the Temp dir. After that the test should pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a change in pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#discussion_r422930910
##########
File path: maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/test/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumerTest.java
##########
@@ -52,9 +52,7 @@
{
GitStatusConsumer consumer = new GitStatusConsumer( new DefaultLog(), null, relativeRepoPath );
- BufferedReader r = new BufferedReader( new FileReader( gitlog ) );
-
- try
+ try ( BufferedReader r = new BufferedReader( new FileReader( gitlog ) ) )
Review comment:
We should create another issue here because it is subject to character conversion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o edited a comment on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626623296
This cannot be real: C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit
Writing into `C:\Windows` is just wrong. I have this dir on my machine: `C:\WINDOWS\System32\config\systemprofile\AppData`. It seems like Jenkins runs a some system account. `Temp` does not exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o edited a comment on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626623296
This cannot be real: C:\Windows\system32\config\systemprofile\AppData\Local\Temp\maven-scm-173513893.commit
Writing into `C:\Windows` is just wrong. I have this dir on my machine: `C:\WINDOWS\System32\config\systemprofile\AppData`. It seems like Jenkins runs a some system account. `Temp` does not exist.
There it is: https://superuser.com/a/598626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] elharo merged pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #101:
URL: https://github.com/apache/maven-scm/pull/101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-scm] michael-o commented on pull request #101: [SCM-937] replace deprecated methods
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #101:
URL: https://github.com/apache/maven-scm/pull/101#issuecomment-626649562
>
>
> If it's the Temp directory that's at fault, there might be a way to avoid that.
What is your proposal then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org