You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/20 01:37:45 UTC
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 11:37 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Summary (updated)
-----------------
CMake: Added subset of agent target in Windows builds.
Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3615
https://issues.apache.org/jira/browse/MESOS-3627
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3633
https://issues.apache.org/jira/browse/MESOS-3658
https://issues.apache.org/jira/browse/MESOS-3659
https://issues.apache.org/jira/browse/MESOS-3660
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
CMake: Added `slave/state.cpp` to Windows builds.
Diffs
-----
CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
Diff: https://reviews.apache.org/r/39220/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/#review103206
-----------------------------------------------------------
Bad patch!
Reviews applied: [39375, 39376, 39377, 39378, 39379, 39380, 39381]
Failed command: ./support/apply-review.sh -n -r 39381
Error:
2015-10-20 04:23:01 URL:https://reviews.apache.org/r/39381/diff/raw/ [760/760] -> "39381.patch" [1]
error: patch failed: src/CMakeLists.txt:166
error: src/CMakeLists.txt: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 19, 2015, 11:37 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39220/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 11:37 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3615
> https://issues.apache.org/jira/browse/MESOS-3627
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3633
> https://issues.apache.org/jira/browse/MESOS-3658
> https://issues.apache.org/jira/browse/MESOS-3659
> https://issues.apache.org/jira/browse/MESOS-3660
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added `slave/state.cpp` to Windows builds.
>
>
> Diffs
> -----
>
> CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
> src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
>
> Diff: https://reviews.apache.org/r/39220/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/#review103357
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39220]
All tests passed.
- Mesos ReviewBot
On Oct. 20, 2015, 10:27 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39220/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 10:27 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added `slave/state.cpp` to Windows builds.
>
>
> Diffs
> -----
>
> CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
> src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
>
> Diff: https://reviews.apache.org/r/39220/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
-----------------------------------------------------------
(Updated Oct. 21, 2015, 3:13 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
Diff: https://reviews.apache.org/r/39220/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/#review103408
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Oct. 20, 2015, 10:27 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39220/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 10:27 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added `slave/state.cpp` to Windows builds.
>
>
> Diffs
> -----
>
> CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
> src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
>
> Diff: https://reviews.apache.org/r/39220/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39220: CMake: Added subset of agent target in
Windows builds.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 10:27 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added `slave/state.cpp` to Windows builds.
Diffs
-----
CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776
src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41
Diff: https://reviews.apache.org/r/39220/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer