You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2014/11/18 22:41:10 UTC
[1/2] cordova-plugin-dialogs git commit: CB-8029 test 1-based
indexing for confirm
Repository: cordova-plugin-dialogs
Updated Branches:
refs/heads/master 305020a52 -> ba96e4ea4
CB-8029 test 1-based indexing for confirm
Added to the expected results -- remember to check 1-based indexing in the
confirm manual tests.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/86b4e25a
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/86b4e25a
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/86b4e25a
Branch: refs/heads/master
Commit: 86b4e25a38c082ddcae1534bfb4f39f8f3819e00
Parents: 24c2665
Author: Staci Cooper <sm...@us.ibm.com>
Authored: Mon Nov 17 14:51:11 2014 -0500
Committer: Staci Cooper <sm...@us.ibm.com>
Committed: Mon Nov 17 14:51:11 2014 -0500
----------------------------------------------------------------------
tests/tests.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/86b4e25a/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index 6e61b00..3924c12 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -142,9 +142,9 @@ exports.defineManualTests = function (contentEl, createActionButton) {
'<p/> <div id="confirm_deprecated"></div>' +
'Expected result: Dialog will say "You pressed confirm". Press Yes, No, or Maybe to close dialog. Status box will tell you what option you selected.' +
'<p/> <div id="confirm"></div>' +
- 'Expected result: Dialog will say "You pressed confirm". Press Yes, No, or Maybe, Not Sure to close dialog. Status box will tell you what option you selected.' +
+ 'Expected result: Dialog will say "You pressed confirm". Press Yes, No, or Maybe, Not Sure to close dialog. Status box will tell you what option you selected, and should use 1-based indexing.' +
'<p/> <div id="prompt"></div>' +
- 'Expected result: Dialog will say "You pressed prompt". Enter any message and press Yes, No, or Maybe, Not Sure to close dialog. Status box will tell you what option you selected and message you entered.' +
+ 'Expected result: Dialog will say "You pressed prompt". Enter any message and press Yes, No, or Maybe, Not Sure to close dialog. Status box will tell you what option you selected and message you entered, and should use 1-based indexing.' +
'<p/> <div id="built_in_alert"></div>' +
'Expected result: Dialog will have title "index.html" and say "You pressed alert" Press OK to close dialog. Nothing will get updated in status box.' +
'<p/> <div id="built_in_confirm"></div>' +
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[2/2] cordova-plugin-dialogs git commit: Merge branch 'CB-8029' of
https://github.com/stacic/cordova-plugin-dialogs
Posted by pu...@apache.org.
Merge branch 'CB-8029' of https://github.com/stacic/cordova-plugin-dialogs
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/ba96e4ea
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/ba96e4ea
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/ba96e4ea
Branch: refs/heads/master
Commit: ba96e4ea47b386dc1e5739ffcb7efa28be458353
Parents: 305020a 86b4e25
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Nov 18 13:39:41 2014 -0800
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Tue Nov 18 13:39:41 2014 -0800
----------------------------------------------------------------------
tests/tests.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/ba96e4ea/tests/tests.js
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org