You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2023/08/11 12:10:19 UTC
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3350: FINERACT-1926: Asset Externalization on Fineract
adamsaghy commented on code in PR #3350:
URL: https://github.com/apache/fineract/pull/3350#discussion_r1291264723
##########
fineract-investor/src/main/java/org/apache/fineract/investor/api/ExternalAssetOwnersApiResourceSwagger.java:
##########
@@ -152,4 +152,57 @@ static final class ExternalAssetOwnerTransferChangesData {
public String purchasePriceRatio;
}
}
+
+ @Schema(description = "GetExternalAssetOwnerSearchRequest")
+ public static final class GetExternalAssetOwnerSearchRequest {
+
+ private GetExternalAssetOwnerSearchRequest() {}
+
+ @Schema(example = "2023-05-23")
+ public String settlementFromDate;
+
+ @Schema(example = "2023-06-23")
+ public String settlementToDate;
+
+ @Schema(example = "2023-05-23")
+ public String effectiveFromDate;
+
+ @Schema(example = "2023-06-23")
+ public String effectiveToDate;
+
+ @Schema(example = "1234567890987654321abc")
+ public String text;
+ }
+
+ @Schema(description = "GetSearchExternalAssetOwnerTransferResponse")
Review Comment:
We dont need this. Swagger can automatically generate this. See `ExternalAssetOwnersApiResource.getTransfers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org