You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/10/21 03:00:47 UTC
[jira] Commented: (HADOOP-4276) The mapred.*ID classes are
inefficient for hashCode and serialization
[ https://issues.apache.org/jira/browse/HADOOP-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641240#action_12641240 ]
Hadoop QA commented on HADOOP-4276:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392453/h4276.patch
against trunk revision 706417.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3501/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3501/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3501/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3501/console
This message is automatically generated.
> The mapred.*ID classes are inefficient for hashCode and serialization
> ---------------------------------------------------------------------
>
> Key: HADOOP-4276
> URL: https://issues.apache.org/jira/browse/HADOOP-4276
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.20.0
>
> Attachments: h4276.patch
>
>
> Currently the ID classes call toString and hash the resulting string rather than computing a hash directly.
> The ID classes also create new instances of the higher level object in readFields (via read) rather than re-using the object via readFields.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.