You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/10/12 11:42:45 UTC

[GitHub] [rocketmq] vongosling commented on a change in pull request #1525: [RIP-18]Add opentracing support for Apache RocketMQ

vongosling commented on a change in pull request #1525: [RIP-18]Add opentracing support for Apache RocketMQ
URL: https://github.com/apache/rocketmq/pull/1525#discussion_r334233873
 
 

 ##########
 File path: client/pom.xml
 ##########
 @@ -33,6 +33,17 @@
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>com.google.guava</groupId>
+            <artifactId>guava</artifactId>
+            <version>23.0</version>
 
 Review comment:
   If I remember correctly, guava has been relied on. No need to do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services