You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "masaori335 (via GitHub)" <gi...@apache.org> on 2023/09/13 01:40:23 UTC
[GitHub] [trafficserver] masaori335 opened a new pull request, #10406: Fix hwloc build
masaori335 opened a new pull request, #10406:
URL: https://github.com/apache/trafficserver/pull/10406
Fix #10405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 merged pull request #10406: Fix hwloc build
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 merged PR #10406:
URL: https://github.com/apache/trafficserver/pull/10406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #10406: Fix hwloc build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10406:
URL: https://github.com/apache/trafficserver/pull/10406#discussion_r1323830488
##########
iocore/aio/Makefile.am:
##########
@@ -21,7 +21,8 @@ AM_CPPFLAGS += \
-I$(abs_top_srcdir)/iocore/io_uring \
-I$(abs_top_srcdir)/include \
-I$(abs_top_srcdir)/lib \
- @SWOC_INCLUDES@
+ @HWLOC_INCLUDES@ \
+ @SWOC_INCLUDES@ \
$(TS_INCLUDES)
Review Comment:
Whoops. Good fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #10406: Fix hwloc build
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #10406:
URL: https://github.com/apache/trafficserver/pull/10406#discussion_r1323841817
##########
iocore/aio/Makefile.am:
##########
@@ -21,7 +21,8 @@ AM_CPPFLAGS += \
-I$(abs_top_srcdir)/iocore/io_uring \
-I$(abs_top_srcdir)/include \
-I$(abs_top_srcdir)/lib \
- @SWOC_INCLUDES@
+ @HWLOC_INCLUDES@ \
+ @SWOC_INCLUDES@ \
$(TS_INCLUDES)
Review Comment:
I don't know why this was not making an error 🤣
##########
iocore/aio/Makefile.am:
##########
@@ -21,7 +21,8 @@ AM_CPPFLAGS += \
-I$(abs_top_srcdir)/iocore/io_uring \
-I$(abs_top_srcdir)/include \
-I$(abs_top_srcdir)/lib \
- @SWOC_INCLUDES@
+ @HWLOC_INCLUDES@ \
+ @SWOC_INCLUDES@ \
$(TS_INCLUDES)
Review Comment:
I don't know why this was not making an error 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org