[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5486: Flink: revise unit test of FlinkUpsert so the table is partitioned by date

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #5486:
URL: https://github.com/apache/iceberg/pull/5486#discussion_r944602570


##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -127,8 +127,8 @@ public void testUpsertAndQuery() {
     LocalDate dt20220302 = LocalDate.of(2022, 3, 2);
 
     sql(
-        "CREATE TABLE %s(id INT NOT NULL, province STRING NOT NULL, dt DATE, PRIMARY KEY(id,province) NOT ENFORCED) "
-            + "PARTITIONED BY (province) WITH %s",
+        "CREATE TABLE %s(id INT NOT NULL, province STRING NOT NULL, dt DATE, PRIMARY KEY(id,dt) NOT ENFORCED) "

Review Comment:
   thanks for making the test more readable.
   
   Can we also change `province` to sth like `name`? Then we can use names like `Jane`, `Joe`. might be slightly easier to follow than `a`, `b`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org