[GitHub] [tvm] tqchen commented on a diff in pull request #14876: [CONTRIB] Enable create_staticlib to take in tar files

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen commented on code in PR #14876:
URL: https://github.com/apache/tvm/pull/14876#discussion_r1197960048


##########
python/tvm/contrib/cc.py:
##########
@@ -83,6 +84,47 @@ def create_shared(output, objects, options=None, cc=None):
         raise ValueError("Unsupported platform")
 
 
+def _linux_ar(output, inputs, ar):
+    ar = ar or "ar"
+
+    libname = os.path.basename(output)
+    if not libname.startswith("lib"):
+        libname = "lib" + libname
+    temp = _utils.tempdir()
+    temp_output = temp.relpath(libname)
+    cmd = [ar, "-crs", temp_output]
+    objects = _tar.untar_files(temp, inputs)

Review Comment:
   Thanks for the comment, i changed to a longer name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org