You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "mynameborat (via GitHub)" <gi...@apache.org> on 2023/06/12 18:15:58 UTC

[GitHub] [samza] mynameborat commented on a diff in pull request #1667: SAMZA-2781: Use framework thread to execute hand-offs and sub-DAG execution

mynameborat commented on code in PR #1667:
URL: https://github.com/apache/samza/pull/1667#discussion_r1227066445


##########
samza-core/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java:
##########
@@ -134,7 +136,8 @@ public final void init(InternalTaskContext internalTaskContext) {
     this.taskModel = taskContext.getTaskModel();
     this.callbackScheduler = taskContext.getCallbackScheduler();
     handleInit(context);
-    this.elasticityFactor = new JobConfig(context.getJobContext().getConfig()).getElasticityFactor();
+    this.elasticityFactor = new JobConfig(config).getElasticityFactor();
+    this.operatorThreadPool = context.getTaskContext().getOperatorExecutor();

Review Comment:
   That is out of scope for this PR as there are other considerations w/ the change to maintain backward semantics and also control which thread pool is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org