You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by da...@apache.org on 2016/04/20 06:55:41 UTC
spark git commit: [MINOR] [SQL] Re-enable `explode()` and
`json_tuple()` testcases in ExpressionToSQLSuite
Repository: spark
Updated Branches:
refs/heads/master 856bc465d -> 6f1ec1f26
[MINOR] [SQL] Re-enable `explode()` and `json_tuple()` testcases in ExpressionToSQLSuite
## What changes were proposed in this pull request?
Since [SPARK-12719: SQL Generation supports for generators](https://issues.apache.org/jira/browse/SPARK-12719) was resolved, this PR enables the related testcases: `explode()` and `json_tuple()`.
## How was this patch tested?
Pass the Jenkins tests (with re-enabled test cases).
Author: Dongjoon Hyun <do...@apache.org>
Closes #12329 from dongjoon-hyun/minor_enable_testcases.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/6f1ec1f2
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/6f1ec1f2
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/6f1ec1f2
Branch: refs/heads/master
Commit: 6f1ec1f2670cd55bc852a810ca9d5c6a2651a9f2
Parents: 856bc46
Author: Dongjoon Hyun <do...@apache.org>
Authored: Tue Apr 19 21:55:29 2016 -0700
Committer: Davies Liu <da...@gmail.com>
Committed: Tue Apr 19 21:55:29 2016 -0700
----------------------------------------------------------------------
.../scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/6f1ec1f2/sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
index bf85d71..4d75bec 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/ExpressionToSQLSuite.scala
@@ -92,8 +92,7 @@ class ExpressionToSQLSuite extends SQLBuilderTest with SQLTestUtils {
checkSqlGeneration("SELECT abs(15), abs(-15)")
checkSqlGeneration("SELECT array(1,2,3)")
checkSqlGeneration("SELECT coalesce(null, 1, 2)")
- // wait for resolution of JIRA SPARK-12719 SQL Generation for Generators
- // checkSqlGeneration("SELECT explode(array(1,2,3))")
+ checkSqlGeneration("SELECT explode(array(1,2,3))")
checkSqlGeneration("SELECT greatest(1,null,3)")
checkSqlGeneration("SELECT if(1==2, 'yes', 'no')")
checkSqlGeneration("SELECT isnan(15), isnan('invalid')")
@@ -200,8 +199,7 @@ class ExpressionToSQLSuite extends SQLBuilderTest with SQLTestUtils {
checkSqlGeneration("SELECT locate('is', 'This is a test', 3)")
checkSqlGeneration("SELECT lpad('SparkSql', 16, 'Learning')")
checkSqlGeneration("SELECT ltrim(' SparkSql ')")
- // wait for resolution of JIRA SPARK-12719 SQL Generation for Generators
- // checkSqlGeneration("SELECT json_tuple('{\"f1\": \"value1\", \"f2\": \"value2\"}','f1')")
+ checkSqlGeneration("SELECT json_tuple('{\"f1\": \"value1\", \"f2\": \"value2\"}','f1')")
checkSqlGeneration("SELECT printf('aa%d%s', 123, 'cc')")
checkSqlGeneration("SELECT regexp_extract('100-200', '(\\d+)-(\\d+)', 1)")
checkSqlGeneration("SELECT regexp_replace('100-200', '(\\d+)', 'num')")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org