You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 00:27:02 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11004: fix: timer component, fixes #10849, closes #11002
codecov-commenter edited a comment on pull request #11004:
URL: https://github.com/apache/incubator-superset/pull/11004#issuecomment-697050930
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=h1) Report
> Merging [#11004](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a6f258747b546c5516d20cc700758fae2d266679?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `78.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11004/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11004 +/- ##
==========================================
+ Coverage 61.47% 61.49% +0.01%
==========================================
Files 816 816
Lines 38371 38367 -4
Branches 3607 3606 -1
==========================================
+ Hits 23589 23594 +5
+ Misses 14596 14587 -9
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.66% <78.94%> (-0.04%)` | :arrow_down: |
| #python | `61.39% <ø> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIudHN4) | `79.16% <77.77%> (-13.70%)` | :arrow_down: |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.34% <0.00%> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.46% <0.00%> (+0.24%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.39% <0.00%> (+0.82%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (+12.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=footer). Last update [a6f2587...d790de8](https://codecov.io/gh/apache/incubator-superset/pull/11004?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org