[GitHub] milleruntime commented on a change in pull request #973: fixes #768 fix race condition in generation of table map

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #973: fixes #768 fix race condition in generation of table map
URL: https://github.com/apache/accumulo/pull/973#discussion_r259048665
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/impl/TableMap.java
 ##########
 @@ -98,4 +106,8 @@ public TableMap(Instance instance, ZooCache zooCache) {
   public Map<String,String> getIdtoNameMap() {
     return tableIdToNameMap;
   }
+
+  public boolean isCurrent(ZooCache zc) {
+    return this.zooCache == zc && this.updateCount == zc.getUpdateCount();
+  }
 
 Review comment:
   This method is nice.  Would it be better to use equals comparison? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services