You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/12 08:24:22 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
HyukjinKwon opened a new pull request #28812:
URL: https://github.com/apache/spark/pull/28812
### What changes were proposed in this pull request?
This proposes a minor refactoring to match `NestedColumnAliasing` to `GeneratorNestedColumnAliasing` so it returns the pruned plan directly.
```scala
case p @ NestedColumnAliasing(nestedFieldToAlias, attrToAliases) =>
NestedColumnAliasing.replaceToAliases(p, nestedFieldToAlias, attrToAliases)
```
vs
```scala
case GeneratorNestedColumnAliasing(p) => p
```
### Why are the changes needed?
Just for readability.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests should cover.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643146628
**[Test build #123911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123911/testReport)** for PR 28812 at commit [`d3a9bef`](https://github.com/apache/spark/commit/d3a9bef1a2c7d1f370327648a4b89cebde9877eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya removed a comment on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
viirya removed a comment on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643383927
> Is the description correct? I cannot find `GeneratorNestedColumnAliasing` in the diff.
Oops. I mis-read the description. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643339692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643338592
**[Test build #123911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123911/testReport)** for PR 28812 at commit [`d3a9bef`](https://github.com/apache/spark/commit/d3a9bef1a2c7d1f370327648a4b89cebde9877eb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643339692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #28812:
URL: https://github.com/apache/spark/pull/28812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643147344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643383927
> Is the description correct? I cannot find `GeneratorNestedColumnAliasing` in the diff.
Oops. I mis-read the description. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643147344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643146628
**[Test build #123911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123911/testReport)** for PR 28812 at commit [`d3a9bef`](https://github.com/apache/spark/commit/d3a9bef1a2c7d1f370327648a4b89cebde9877eb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643507059
okay, thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28812: [SPARK-31977][SQL] Returns the plan directly from NestedColumnAliasing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28812:
URL: https://github.com/apache/spark/pull/28812#issuecomment-643758126
Thanks @viirya and @maropu!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org