You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/24 17:48:51 UTC

[GitHub] [systemml] mboehm7 commented on pull request #896: [MINOR] Python Lineage Trace Test Change

mboehm7 commented on pull request #896:
URL: https://github.com/apache/systemml/pull/896#issuecomment-619157501


   LGTM - thanks @Baunsgaard. In general this is fine, but in the future, it would be good to preserve the history for renamed/moved files (`src/main/python/tests/test_lineagetrace.py` to
   `src/main/python/tests/lineage/test_lineagetrace.py`). What usually works is to first rename it, commit, and make the necessary changes in a subsequent commit. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org