[GitHub] [ignite] timoninmaxim commented on a change in pull request #8557: IGNITE-13829: Added log rotation to ducktape-tests

[GitBox <gi...@apache.org>]

timoninmaxim commented on a change in pull request #8557:
URL: https://github.com/apache/ignite/pull/8557#discussion_r540194445



##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py
##########
@@ -102,12 +102,13 @@ class IgniteNodeSpec(IgniteSpec, IgnitePersistenceAware):
     """
     @property
     def command(self):
-        cmd = "%s %s %s %s 2>&1 | tee -a %s &" % \
+        cmd = "%s %s %s %s 2>&1 | tee %s >> %s &" % \
               (self._envs(),
                self.path.script("ignite.sh"),
                self._jvm_opts(),
                self.CONFIG_FILE,
-               self.STDOUT_STDERR_CAPTURE)
+               self.STDOUT_STDERR_CAPTURE,
+               self.STDOUT_STDERR_ALL)

Review comment:
       > just set offset not to 0 but to the position related to the restart when from_the_beginning is true
   
   Hi! I suggest to use separate file for last run for monitor purposes. Setting offset will require getting the offset from somewhere, storing that. Also there could be issues with unplanned restarts of a service. All this is an additional code, checks and we can just use separate file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org