[GitHub] [pulsar] zymap commented on a diff in pull request #15893: [tiered-storage] add s3 compatible storage provider for the offloader

[GitBox <gi...@apache.org>]

zymap commented on code in PR #15893:
URL: https://github.com/apache/pulsar/pull/15893#discussion_r889766997


##########
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPoliciesImpl.java:
##########
@@ -66,7 +66,7 @@ public class OffloadPoliciesImpl implements Serializable, OffloadPolicies {
     public static final int DEFAULT_OFFLOAD_MAX_THREADS = 2;
     public static final int DEFAULT_OFFLOAD_MAX_PREFETCH_ROUNDS = 1;
     public static final ImmutableList<String> DRIVER_NAMES = ImmutableList
-            .of("S3", "aws-s3", "google-cloud-storage", "filesystem", "azureblob", "aliyun-oss");
+      .of("S3", "aws-s3", "google-cloud-storage", "filesystem", "azureblob", "s3-compatible-storage");

Review Comment:
   It's better to keep the original style, this change will break some users who already take it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org