You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Charles Reiss (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 05:24:32 UTC
[jira] [Created] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Resources of tasks queued during executor launch not always accounted for
-------------------------------------------------------------------------
Key: MESOS-56
URL: https://issues.apache.org/jira/browse/MESOS-56
Project: Mesos
Issue Type: Bug
Components: isolation, slave
Reporter: Charles Reiss
Assignee: Charles Reiss
When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149957#comment-13149957 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/
-----------------------------------------------------------
(Updated 2011-11-14 21:39:43.394595)
Review request for mesos.
Summary
-------
This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
This addresses bug MESOS-56.
https://issues.apache.org/jira/browse/MESOS-56
Diffs (updated)
-----
src/slave/slave.cpp de5716c
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2669/diff
Testing
-------
Modification to MasterTest included.
Thanks,
Charles
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149955#comment-13149955 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/
-----------------------------------------------------------
(Updated 2011-11-14 21:34:18.836757)
Review request for mesos.
Summary
-------
This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
This addresses bug MESOS-56.
https://issues.apache.org/jira/browse/MESOS-56
Diffs (updated)
-----
src/slave/slave.cpp de5716c
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2669/diff
Testing
-------
Modification to MasterTest included.
Thanks,
Charles
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149830#comment-13149830 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3209
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/2669/#comment7128>
s/start/start.
src/slave/slave.cpp
<https://reviews.apache.org/r/2669/#comment7126>
Let's keep this down by the actual RunTaskMessage for consistency with the other RunTaskMessage usage.
src/slave/slave.cpp
<https://reviews.apache.org/r/2669/#comment7130>
This is great. But three things: (1) let's tweak this comment to include the fact that we are changing the resources _after_ we have accounted for the tasks; (2) possibly include a TODO or NOTE that says that given the asynchronous nature of the dispatch this still might not be sufficient for guaranteeing that the resource limits have been changed before the executor starts running the task; and (3) also change the other place in the code where we send a RunTaskMessage to a slave to dispatch to the isolation module before we send the message.
src/tests/master_tests.cpp
<https://reviews.apache.org/r/2669/#comment7132>
Unless I'm mistaken, because of the async nature of the isolation module there is no happens-before relationship in the code that guarantees that the isolation module will have gotten a "resourcesChanged" before the slave gets a status update from the executor that it sends back to the scheduler. I'd rather you add a TODO in the code to try and capture the fact that resources have been updated then doing it this way for now.
- Benjamin
On 2011-11-02 05:51:36, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-02 05:51:36)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155725#comment-13155725 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3468
-----------------------------------------------------------
Ship it!
We're going to commit this but just kill the orphaned line.
src/tests/utils.hpp
<https://reviews.apache.org/r/2669/#comment7736>
I think this is an orphaned line ...
- Benjamin
On 2011-11-21 03:23:26, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-21 03:23:26)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155730#comment-13155730 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/
-----------------------------------------------------------
(Updated 2011-11-23 07:02:41.806738)
Review request for mesos.
Summary
-------
This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
This addresses bug MESOS-56.
https://issues.apache.org/jira/browse/MESOS-56
Diffs (updated)
-----
src/slave/slave.cpp de5716c
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 89af7f3
Diff: https://reviews.apache.org/r/2669/diff
Testing
-------
Modification to MasterTest included.
Thanks,
Charles
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141942#comment-13141942 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/
-----------------------------------------------------------
Review request for mesos.
Summary
-------
This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
This addresses bug MESOS-56.
https://issues.apache.org/jira/browse/MESOS-56
Diffs
-----
src/slave/slave.cpp de5716c
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2669/diff
Testing
-------
Modification to MasterTest included.
Thanks,
Charles
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149956#comment-13149956 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
bq. On 2011-11-14 19:21:12, Benjamin Hindman wrote:
bq. > src/slave/slave.cpp, line 750
bq. > <https://reviews.apache.org/r/2669/diff/1/?file=55784#file55784line750>
bq. >
bq. > s/start/start.
Done.
bq. On 2011-11-14 19:21:12, Benjamin Hindman wrote:
bq. > src/slave/slave.cpp, line 755
bq. > <https://reviews.apache.org/r/2669/diff/1/?file=55784#file55784line755>
bq. >
bq. > Let's keep this down by the actual RunTaskMessage for consistency with the other RunTaskMessage usage.
Done.
bq. On 2011-11-14 19:21:12, Benjamin Hindman wrote:
bq. > src/slave/slave.cpp, lines 758-759
bq. > <https://reviews.apache.org/r/2669/diff/1/?file=55784#file55784line758>
bq. >
bq. > This is great. But three things: (1) let's tweak this comment to include the fact that we are changing the resources _after_ we have accounted for the tasks; (2) possibly include a TODO or NOTE that says that given the asynchronous nature of the dispatch this still might not be sufficient for guaranteeing that the resource limits have been changed before the executor starts running the task; and (3) also change the other place in the code where we send a RunTaskMessage to a slave to dispatch to the isolation module before we send the message.
Done.
bq. On 2011-11-14 19:21:12, Benjamin Hindman wrote:
bq. > src/tests/master_tests.cpp, lines 137-138
bq. > <https://reviews.apache.org/r/2669/diff/1/?file=55785#file55785line137>
bq. >
bq. > Unless I'm mistaken, because of the async nature of the isolation module there is no happens-before relationship in the code that guarantees that the isolation module will have gotten a "resourcesChanged" before the slave gets a status update from the executor that it sends back to the scheduler. I'd rather you add a TODO in the code to try and capture the fact that resources have been updated then doing it this way for now.
I agree. Changed the test to wait for an resourcesChanged() call, so we have a test that resourcesChanged() is eventually called with the correct value.
Added TODOs to both the dispatch(...resourcesChanged) in the slave. I'll also file a separate JIRA about this; it probably needs a IsolationModule API change.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3209
-----------------------------------------------------------
On 2011-11-14 21:34:18, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-14 21:34:18)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155729#comment-13155729 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
bq. On 2011-11-23 06:49:29, Benjamin Hindman wrote:
bq. > src/tests/utils.hpp, line 269
bq. > <https://reviews.apache.org/r/2669/diff/4/?file=59546#file59546line269>
bq. >
bq. > I think this is an orphaned line ...
Removed.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3468
-----------------------------------------------------------
On 2011-11-23 07:02:41, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-23 07:02:41)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 89af7f3
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153965#comment-13153965 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
bq. On 2011-11-14 22:24:48, Benjamin Hindman wrote:
bq. > src/tests/utils.hpp, line 313
bq. > <https://reviews.apache.org/r/2669/diff/3/?file=58102#file58102line313>
bq. >
bq. > Kill this now (unused code).
Done.
bq. On 2011-11-14 22:24:48, Benjamin Hindman wrote:
bq. > src/tests/utils.hpp, line 247
bq. > <https://reviews.apache.org/r/2669/diff/3/?file=58102#file58102line247>
bq. >
bq. > Put '{' on newline and add a small comment explaining why we mock out 'resourcesChanged' (e.g., to be able to trigger for testing purposes).
Done. (Comment added next to MOCK_METHOD...().)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3239
-----------------------------------------------------------
On 2011-11-21 03:23:26, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-21 03:23:26)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150007#comment-13150007 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/#review3239
-----------------------------------------------------------
Ship it!
Hotness, let's get this committed.
src/tests/utils.hpp
<https://reviews.apache.org/r/2669/#comment7229>
Put '{' on newline and add a small comment explaining why we mock out 'resourcesChanged' (e.g., to be able to trigger for testing purposes).
src/tests/utils.hpp
<https://reviews.apache.org/r/2669/#comment7228>
Kill this now (unused code).
- Benjamin
On 2011-11-14 21:39:43, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2669/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-14 21:39:43)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
bq.
bq.
bq. This addresses bug MESOS-56.
bq. https://issues.apache.org/jira/browse/MESOS-56
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/slave/slave.cpp de5716c
bq. src/tests/master_tests.cpp 2438114
bq. src/tests/utils.hpp 02772f7
bq.
bq. Diff: https://reviews.apache.org/r/2669/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modification to MasterTest included.
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "Charles Reiss (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss resolved MESOS-56.
--------------------------------
Resolution: Fixed
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-56) Resources of tasks queued during
executor launch not always accounted for
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153964#comment-13153964 ]
jiraposter@reviews.apache.org commented on MESOS-56:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2669/
-----------------------------------------------------------
(Updated 2011-11-21 03:23:26.723463)
Review request for mesos.
Summary
-------
This calls Executor::addTask to accumulate the usage of queued tasks before calling resourcesChanged() to ensure the executor has enough resources to run those queued tasks.
This addresses bug MESOS-56.
https://issues.apache.org/jira/browse/MESOS-56
Diffs (updated)
-----
src/slave/slave.cpp de5716c
src/tests/master_tests.cpp 2438114
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2669/diff
Testing
-------
Modification to MasterTest included.
Thanks,
Charles
> Resources of tasks queued during executor launch not always accounted for
> -------------------------------------------------------------------------
>
> Key: MESOS-56
> URL: https://issues.apache.org/jira/browse/MESOS-56
> Project: Mesos
> Issue Type: Bug
> Components: isolation, slave
> Reporter: Charles Reiss
> Assignee: Charles Reiss
>
> When initially launching an executor, the slave queues the tasks sent to the executor until the executor registers itself with the slave. When this happens, the slave calls resourcesChanged() on the isolation module, but before it adds the usage of the queued tasks.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira