[GitHub] storm pull request #1744: STORM-1276: line for line translation of nimbus to...

[erikdw <gi...@git.apache.org>]

Github user erikdw commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1744#discussion_r89243737
  
    --- Diff: storm-core/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
    @@ -304,6 +307,41 @@ public void readBlobTo(String key, OutputStream out, Subject who) throws IOExcep
         }
     
         /**
    +     * Read a stored topology helper method
    +     * @param topoId the id of the topology to read
    +     * @param who who to read it as
    +     * @return the deserialized topology.
    +     * @throws IOException on any error while reading the blob.
    +     * @throws AuthorizationException if who is not allowed to read the blob
    +     * @throws KeyNotFoundException if the blob could not be found
    +     */
    +    public StormTopology readTopology(String topoId, Subject who) throws KeyNotFoundException, AuthorizationException, IOException {
    +        return Utils.deserialize(readBlob(ConfigUtils.masterStormCodeKey(topoId), who), StormTopology.class);
    +    }
    +    
    +    /**
    +     * Read a stored topology config helper method
    +     * @param topoId the id of the topology whos conf we are reading
    --- End diff --
    
    nit: whos -> whose


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---