You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/12/14 15:31:42 UTC
[commons-numbers] 06/06: Nit (less verbose unit tests).
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git
commit a9cd5d9c510a4323bb05f822be440526e3b5d068
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Fri Dec 14 16:30:02 2018 +0100
Nit (less verbose unit tests).
---
.../commons/numbers/quaternion/QuaternionTest.java | 30 +++++++++-------------
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
index bce52da..5d5f99b 100644
--- a/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
+++ b/commons-numbers-quaternion/src/test/java/org/apache/commons/numbers/quaternion/QuaternionTest.java
@@ -470,42 +470,36 @@ public class QuaternionTest {
@Test
public final void testPositivePolarFormWhenScalarPositive() {
- Quaternion q = Quaternion.of(3, -3, -3, 3);
- Quaternion actual = q.positivePolarForm();
+ Quaternion q = Quaternion.of(3, -3, -3, 3).positivePolarForm();
Quaternion expected = Quaternion.of(0.5, -0.5, -0.5, 0.5);
- assertEquals(actual, expected, EPS);
+ assertEquals(q, expected, EPS);
- Assert.assertTrue(actual.positivePolarForm() == actual);
+ Assert.assertTrue(q.positivePolarForm() == q);
}
@Test
public final void testPositivePolarFormWhenScalarNegative() {
- Quaternion q = Quaternion.of(-3, 3, -3, 3);
- Quaternion actual = q.positivePolarForm();
+ Quaternion q = Quaternion.of(-3, 3, -3, 3).positivePolarForm();
Quaternion expected = Quaternion.of(0.5, -0.5, 0.5, -0.5);
- assertEquals(actual, expected, EPS);
+ assertEquals(q, expected, EPS);
- Assert.assertTrue(actual.positivePolarForm() == actual);
+ Assert.assertTrue(q.positivePolarForm() == q);
}
@Test
public final void testPositivePolarFormWhenScalarPositiveAndNormalized() {
- Quaternion q = Quaternion.of(3, -3, -3, 3).normalize();
- Quaternion actual = q.positivePolarForm();
- Quaternion expected = Quaternion.of(0.5, -0.5, -0.5, 0.5);
- assertEquals(actual, expected, EPS);
+ Quaternion q = Quaternion.of(123, 45, 67, 89).normalize().positivePolarForm();
- Assert.assertTrue(actual.positivePolarForm() == actual);
+ Assert.assertTrue(q.getW() >= 0);
+ Assert.assertTrue(q.positivePolarForm() == q);
}
@Test
public final void testPositivePolarFormWhenScalarNegativeAndNormalized() {
- Quaternion q = Quaternion.of(-3, 3, -3, 3).normalize();
- Quaternion actual = q.positivePolarForm();
- Quaternion expected = Quaternion.of(0.5, -0.5, 0.5, -0.5);
- assertEquals(actual, expected, EPS);
+ Quaternion q = Quaternion.of(123, 45, 67, 89).normalize().negate().positivePolarForm();
- Assert.assertTrue(actual.positivePolarForm() == actual);
+ Assert.assertTrue(q.getW() >= 0);
+ Assert.assertTrue(q.positivePolarForm() == q);
}
@Test