You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/03/28 16:47:00 UTC
[jira] [Resolved] (FINERACT-696) use SpotBugs and findbugs-slf4j to
detect bad logging anti-patterns
[ https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Vorburger resolved FINERACT-696.
----------------------------------------
Resolution: Fixed
> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> -------------------------------------------------------------------
>
> Key: FINERACT-696
> URL: https://issues.apache.org/jira/browse/FINERACT-696
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Build
> Reporter: Michael Vorburger
> Assignee: Michael Vorburger
> Priority: Major
> Labels: beginner, starter
> Fix For: 1.4.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While code reviewing [https://github.com/apache/fineract/pull/464], I came accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but just an automated build failure. This is possible using SpotBugs (not FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible successor) and [https://github.com/KengoTODA/findbugs-slf4j/] (for this particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but using findbugs-slf4j for Fineract would have value even before that's implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just waiting to have issues to working on (I'm joking) - so I was wondering if perhaps you knew of anyone who would be willing to work on this one?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)