[jira] [Commented] (MESOS-8033) Use more idiomatic CMake for compiler features

["Joseph Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188890#comment-16188890 ] 

Joseph Wu commented on MESOS-8033:
----------------------------------

{code}
commit bd5e874c22f0d16fc5494213d319065cf9107d0f
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Date:   Mon Oct 2 14:33:52 2017 -0700

    CMake: Removed `MESOS_CPPFLAGS` variable.
    
    This was a magic variable that was used to add compiler definitions
    globally. Instead, global definitions are now added explicitly with
    `add_definitions`, and others with `target_compile_definitions`.
    
    Review: https://reviews.apache.org/r/62731/
{code}

> Use more idiomatic CMake for compiler features
> ----------------------------------------------
>
>                 Key: MESOS-8033
>                 URL: https://issues.apache.org/jira/browse/MESOS-8033
>             Project: Mesos
>          Issue Type: Improvement
>          Components: cmake
>            Reporter: Andrew Schwartzmeyer
>            Priority: Minor
>              Labels: cmake
>
> Specifically, we should replace
> {noformat}
>   string(APPEND CMAKE_CXX_FLAGS " -std=c++11")
> {noformat}
> With {{CMAKE_CXX_STANDARD}}, and use [compile feature requirements|https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#compile-feature-requirements].
> And replace
> {noformat}
>   string(APPEND CMAKE_CXX_FLAGS " -Wformat-security")
> {noformat}
> With compile options instead of appending to {{CMAKE_CXX_FLAGS}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)