You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by aparnard <gi...@git.apache.org> on 2016/08/09 22:32:47 UTC

[GitHub] incubator-geode pull request #229: Fixing lucene gfsh bugs

GitHub user aparnard opened a pull request:

    https://github.com/apache/incubator-geode/pull/229

    Fixing lucene gfsh bugs

    - If an index is created on an existing region, an exception is thrown, but the index is still stored in definedIndexMap. This is fixed by removing the index definition before the exception is thrown. Added a test to verify
    - Previously, the describe/search index gfsh command on definied indexes returned an exception. Changed the behavior to return a message. Added dunit test to verify
    - Changed Search index command to "search lucene" (previously "lucene search")


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aparnard/incubator-geode feature/GEODE-11-remove-from-definedIndex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 7b9fb3e8e3472ec79b73ee4250910ea061458513
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-09T20:56:02Z

    GEODE-11: Fixing bug in definedIndexMap in LuceneServiceImpl
    If an index is created on an existing region, an exception is thrown, but the index is still stored in definedIndexMap. This is fixed by removing the index definition before the exception is thrown. Added a test to verify

commit 296064c389a73b9162dbbc065e612918b063c8e4
Author: Aparna Dharmakkan <ad...@pivotal.io>
Date:   2016-08-09T21:32:43Z

    GEODE-11: Describe/Search index gfsh commands returns error message when region not created
    
    - Previously, the describe/search index gfsh command on definied indexes returned an exception. Changed the behavior to return a message. Added dunit test to verify
    - Changed Search index command to "search lucene" (previously "lucene search")

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #229: Fixing lucene gfsh bugs

Posted by gesterzhou <gi...@git.apache.org>.
Github user gesterzhou commented on the issue:

    https://github.com/apache/incubator-geode/pull/229
  
    +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #229: Fixing lucene gfsh bugs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---