You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Raul Gutierrez Segales <rg...@itevenworks.net> on 2014/07/07 19:03:48 UTC

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23081/
-----------------------------------------------------------

(Updated July 7, 2014, 5:03 p.m.)


Review request for zookeeper, fpj, michim, Patrick Hunt, Rakesh R, and Thawan Kooburat.


Changes
-------

make sure it compiles in OS X. 


Bugs: ZOOKEEPER-827
    https://issues.apache.org/jira/browse/ZOOKEEPER-827


Repository: zookeeper-git


Description (updated)
-------

commit 4df2128848eef09b1cc25b13b1edc585f095f40f
Author: Raul Gutierrez S <rg...@itevenworks.net>
Date:   Sun Jun 8 21:43:48 2014 -0700

    ZOOKEEPER-827. enable r/o mode in C client library
    
    Signed-off-by: Raul Gutierrez S <rg...@itevenworks.net>

:100644 100644 6130c4d... a7b2621... M	src/c/Makefile.am
:100644 100644 fe25015... 045ef9a... M	src/c/README
:100644 100644 d5a3876... 18a203d... M	src/c/include/zookeeper.h
:100644 100644 4134044... e641a46... M	src/c/src/addrvec.c
:100644 100644 5345ebc... 3897095... M	src/c/src/addrvec.h
:100644 100644 aab214d... a9d11e1... M	src/c/src/cli.c
:100644 100644 0d3ae19... 0c513e8... M	src/c/src/load_gen.c
:100644 100644 21dc70c... eec505c... M	src/c/src/zk_adaptor.h
:100644 100644 795875e... 782ac52... M	src/c/src/zookeeper.c
:100644 100644 41d5179... c6536dc... M	src/c/tests/TestClientRetry.cc
:000000 100644 0000000... 37ab147... A	src/c/tests/TestReadOnlyClient.cc
:000000 100644 0000000... 035f26d... A	src/c/tests/WatchUtil.h
:100644 100644 f97c943... 263f3ce... M	src/c/tests/ZKMocks.cc
:100644 100644 fbcfc4f... 2717ded... M	src/c/tests/ZKMocks.h
:000000 100644 0000000... aa2dd8c... A	src/c/tests/quorum.cfg
:100755 100755 0af80f8... 33ab152... M	src/c/tests/zkServer.sh


Diffs (updated)
-----

  src/c/Makefile.am 6130c4d 
  src/c/README fe25015 
  src/c/include/zookeeper.h d5a3876 
  src/c/src/addrvec.h 5345ebc 
  src/c/src/addrvec.c 4134044 
  src/c/src/cli.c aab214d 
  src/c/src/load_gen.c 0d3ae19 
  src/c/src/zk_adaptor.h 21dc70c 
  src/c/src/zookeeper.c 795875e 
  src/c/tests/TestClientRetry.cc 41d5179 
  src/c/tests/TestReadOnlyClient.cc PRE-CREATION 
  src/c/tests/WatchUtil.h PRE-CREATION 
  src/c/tests/ZKMocks.h fbcfc4f 
  src/c/tests/ZKMocks.cc f97c943 
  src/c/tests/quorum.cfg PRE-CREATION 
  src/c/tests/zkServer.sh 0af80f8 

Diff: https://reviews.apache.org/r/23081/diff/


Testing
-------

all tests pass, *should* compile on Windows. 


Thanks,

Raul Gutierrez Segales