You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 20:36:59 UTC

[GitHub] [arrow] lidavidm opened a new pull request #10319: ARROW-12780: [CI][C++] Try to fix MinGW builds

lidavidm opened a new pull request #10319:
URL: https://github.com/apache/arrow/pull/10319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10319: ARROW-12780: [CI][C++] Try to fix MinGW builds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840819138


   https://issues.apache.org/jira/browse/ARROW-12780


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #10319: ARROW-12780: [CI][C++] Try to fix MinGW builds

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#discussion_r632099902



##########
File path: ci/scripts/msys2_setup.sh
##########
@@ -34,6 +34,7 @@ case "${target}" in
     packages+=(${MINGW_PACKAGE_PREFIX}-gflags)
     packages+=(${MINGW_PACKAGE_PREFIX}-grpc)
     packages+=(${MINGW_PACKAGE_PREFIX}-gtest)
+    packages+=(${MINGW_PACKAGE_PREFIX}-libxml2)
     packages+=(${MINGW_PACKAGE_PREFIX}-libutf8proc)

Review comment:
       Could you fix order?
   
   ```suggestion
       packages+=(${MINGW_PACKAGE_PREFIX}-libutf8proc)
       packages+=(${MINGW_PACKAGE_PREFIX}-libxml2)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #10319: ARROW-12780: [CI][C++] Install necessary packages for MinGW builds

Posted by GitBox <gi...@apache.org>.
kou closed pull request #10319:
URL: https://github.com/apache/arrow/pull/10319


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10319: ARROW-12780: [CI][C++] Install necessary packages for MinGW builds

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840904722


   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm commented on pull request #10319: ARROW-12780: [CI][C++] Install necessary packages for MinGW builds

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840883095


   Title & order fixed, thank you!
   
   I kicked Travis again, though it seems unrelated, and the integration build should be fixed by #10314.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10319: ARROW-12780: [CI][C++] Try to fix MinGW builds

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10319:
URL: https://github.com/apache/arrow/pull/10319#issuecomment-840831281


   Could you also improve the title?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org