You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/07/01 00:13:08 UTC
Re: Review Request 60571: Cluster and Host Versions Can Change to
CURRENT on their Own During an Upgrade
> On June 30, 2017, 5:01 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
> > Lines 1318 (patched)
> > <https://reviews.apache.org/r/60571/diff/3/?file=1767902#file1767902line1318>
> >
> > Minor suggestion: Could use CollectionUtils.
Fixed.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60571/#review179408
-----------------------------------------------------------
On June 30, 2017, 4:36 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60571/
> -----------------------------------------------------------
>
> (Updated June 30, 2017, 4:36 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai and Sid Wagle.
>
>
> Bugs: AMBARI-21389
> https://issues.apache.org/jira/browse/AMBARI-21389
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21361 introduced some code from {{trunk}} which works correctly with patch/service upgrades on that branch. However, on Ambari 2.5 ({{branch-2.5}}) it causes host versions and cluster versions to transition incorrectly to {{CURRENT}} during the upgrade.
>
> This prevents finalization.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/annotations/Experimental.java f51991c8c8
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java 1d5ba0e9e9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 822f94d5fb
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java 4600912fa7
> ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java 7b8b68a77c
>
>
> Diff: https://reviews.apache.org/r/60571/diff/3/
>
>
> Testing
> -------
>
> PENDING
>
>
> Thanks,
>
> Jonathan Hurley
>
>